The GitHub Actions job "License checker" on 
rocketmq.git/codex/server-socket-backlog has succeeded.
Run started by GitHub user iloveeyjafjalla (triggered by RongtongJin).

Head commit for run:
34b1d6ceb810e5e5fc82daec4a728563f497104d / iloveeyjafjalla <[email protected]>
[ISSUE #11396] fix(remoting): apply serverSocketBacklog to the accept backlog

NettyServerConfig#serverSocketBacklog (and the rocketmq.remoting.socket.backlog
property) is settable, but nothing read its getter: initServerBootstrap passed a
literal 1024 to ChannelOption.SO_BACKLOG. This is a regression of #3528/#3529
("The value of ChannelOption.SO_BACKLOG can not be hard-coded") - the RIP-31
BrokerContainer refactor reverted that single line while keeping the field, its
accessors and the property, so tuning the backlog for a broker, nameserver or
proxy that has to absorb connection bursts silently did nothing.

Use this.nettyServerConfig.getServerSocketBacklog() again.

Report URL: https://github.com/apache/rocketmq/actions/runs/38347127956

With regards,
GitHub Actions via GitBox

Reply via email to