lizhimins commented on PR #6379:
URL: 
https://github.com/apache/rocketmq-dashboard/pull/6379#issuecomment-6189372682

   Consolidated into #6367 and merged into `rocketmq-studio` as 
[`0e73d2890`](https://github.com/apache/rocketmq-dashboard/commit/0e73d2890b36cc5c9401404c7bbb1aba27d3c84a).
 Your commit went in with its original authorship, so nothing is lost by 
closing this PR.
   
   **What landed from this PR:** distinguish a missing audit target/scope from 
a literal placeholder.
   
   Nine frontend fixes by the same author (#6367 #6369 #6373 #6375 #6376 #6379 
#6380 #6382 #6653) touched an overlapping set of files — 
`MetricsExplorer.test.tsx` alone was appended to by two of them — so they were 
reviewed as one unit and merged as one commit instead of nine trunk commits 
landing hours apart. Verification on the merged branch: 159 test files / 1666 
tests green, `prettier --check` clean, `eslint` 0 errors (2 pre-existing 
warnings), and every added line of all nine source PRs confirmed present.
   
   `Fixes #6360` does not auto-close because the merge target `rocketmq-studio` 
is not the default branch, so #6360 is being closed separately with a reference 
to the merged commit.
   
   Thanks for the fix, and sorry for the extra hop.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to