lizhimins opened a new pull request, #6724:
URL: https://github.com/apache/rocketmq-dashboard/pull/6724

   ## Why
   
   `rocketmq-studio` currently fails `mvn test` at the checkstyle `validate` 
phase:
   
   ```
   [ERROR] RocketMQAdminClientImplTest.java:85:1: Duplicate import to line 82
           - org.junit.jupiter.params.provider.CsvSource. [RedundantImport]
   ```
   
   ## How it happened
   
   #6652, #6651 and #6655 were three independent fixes to 
`RocketMQAdminClientImpl`,
   each based on a commit where this test file had no `CsvSource` import. Each 
one
   added the import; git merged the three additions without a conflict because 
they
   landed on different lines, so the trunk ended up with it twice.
   
   The repository does not gate merges on CI checks, so this reached the branch
   before anyone built it.
   
   ## What this does
   
   Deletes the second import. No behaviour change; the parameterized tests 
added by
   all three PRs keep working.
   
   ## Verification
   
   `mvn -B -ntp test` on this branch: **3698 tests, 0 failures, 0 errors,
   BUILD SUCCESS** (checkstyle passes).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to