lizhimins commented on PR #6512: URL: https://github.com/apache/rocketmq-dashboard/pull/6512#issuecomment-6190307357
Closing this one: Thanks for the thorough analysis. This one is now obsolete on `rocketmq-studio`: the in-page route diagnostics block was removed from `web/src/pages/instance/topic.tsx`, and `web/src/utils/topicRouteDiagnostics.ts` plus its test no longer exist on the branch (the merge reports modify/delete conflicts). We no longer render per-route health conclusions or recommendations in the page, so there is nothing left for the coverage-count fix to correct. The salvageable part is documentation only: `docs/api-spec.md` for `GET /api/topics/:name/routes` is genuinely missing `masterAddr`, `brokerAddrs` and `brokerIds`, which `BrokerRouteVO` does return — please send that as a small docs-only PR (without the paragraph describing the removed diagnostics). The "explicit empty topology must not fall back to `brokerAddr`" insight is worth keeping in mind if we ever compute coverage server-side. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
