lizhimins commented on PR #6486: URL: https://github.com/apache/rocketmq-dashboard/pull/6486#issuecomment-6190303202
Closing in favour of #6445, which is now merged into `rocketmq-studio` as `0927d5cfc`. The diagnosis is correct and we agree with the fix: `AlertRuleEvaluator.java:58-59` used the total-order `Double.compare` for `==`/`!=` while the other four operators in the same switch use primitive comparison, and `AlertRuleSemanticFingerprint.java:73-75` already normalises both zeros to one identity — so a `-0.0` threshold was simultaneously "the same rule" for duplicate detection and "never equal" for evaluation. Your three-line comment is the clearest statement of that argument we have seen and we would like to carry it into the merged version. We are closing this as a duplicate of **#6445**, which fixes the identical two lines for the same issue (#6440) but with stronger tests: a four-row `@CsvSource` that covers both `0.0/-0.0` and `-0.0/0.0` **and** exercises the percentage-normalisation path (`thresholdUnit = "%"`), plus a `Math.nextUp` control proving no epsilon was smuggled in. Your branch has one `@Test` with two assertions and no percentage case, and it sits five commits further back from the current base. Salvage path if you want to keep contributing here: review #6445 and send the comment wording (or the percentage-normalisation case, if you think it is still missing) as a follow-up against that shape. One process note: please search open PRs by `Fixes #<issue>` before submitting — five of your six PRs in this round restate a defect another contributor has already patched. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
