lizhimins commented on PR #6378: URL: https://github.com/apache/rocketmq-dashboard/pull/6378#issuecomment-6190900873
Closing in favour of #6377, now merged into `rocketmq-studio` as [`baf70ae6a`](https://github.com/apache/rocketmq-dashboard/commit/baf70ae6a). Thanks — the underlying bug is real and well evidenced: `queriedAt` is captured before the await (`MetricsExplorer.tsx:610`) while the merge happens on completion (`:694`, `:804`), and `loadMetricsQueryHistory` already sorts newest-first (`metricsExplorerDiagnostics.ts:431`), so trunk contradicts itself. Two things before this can land. (1) It collides with #6377, which fixes the same function with the same `sort` — and its ordering is safer: dedup-after-sort keeps the newest run per identity, whereas dedup-before-sort here means a slow older completion of the *same* query overwrites the newer run's entry. Please rebase onto that approach (or let us take #6377 and close this one) and add a case where the incoming entry shares an identity with a newer stored entry. (2) Please drop the unrelated Prettier reflow of the nested ternary in `buildMetricSeriesDetailRows` and of the existing assertions in `metricsExplorerDiagnostics.test.ts`, or split it into a separate `style:` commit . Note we confirmed the 19 deleted test lines are pure reformatting with no assertion loss. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
