The GitHub Actions job "CI" on 
rocketmq-dashboard.git/fix/litetopic-unknown-sort-last has failed.
Run started by GitHub user lizhimins (triggered by lizhimins).

Head commit for run:
83604fca8520d4925dc73a7dc30073713751a988 / Apulupie 
<[email protected]>
fix(litetopic): keep an unmeasured TTL and last-active time out of the first 
sort position

Two sortable columns of the Lite topic table rank a pattern the provider could 
not measure as if
it were the smallest value: the average TTL as a zero TTL and the last-active 
instant as epoch 0,
while the cells render `-` for the same rows (`LiteTopic.tsx` `formatDuration` 
/ `formatTime`).

The provider leaves both fields unset: `RocketMQLiteTopicProvider.buildSummary` 
only sets
`lastActiveTime` after a session reported an access (a pattern with no 
connected consumer therefore
carries none), and `toMillis` returns null when the broker has no TTL 
attribute, which is exactly
the case whose TTL status the page already classifies as unknown. Sorting 
ascending by either column
put those patterns first, so a reader looking for the shortest TTL or the 
longest idle time saw
unmeasured rows claim those positions.

Both sorters now use a sort-order-aware key that keeps an unset value last in 
both directions, the
same technique `BrokerCluster.tsx` uses for an unmeasured TPS: Ant Design 
negates the comparator for
a descending column, so an unset value cannot simply sort as the lowest number. 
The other three
sortable columns are untouched because their fields are always set 
(`topicCount` is floored at 0,
`consumerCount` and `totalBacklog` are counters).

Report URL: 
https://github.com/apache/rocketmq-dashboard/actions/runs/38721300173

With regards,
GitHub Actions via GitBox

Reply via email to