lizhimins opened a new pull request, #6735:
URL: https://github.com/apache/rocketmq-dashboard/pull/6735
## Why
`rocketmq-studio` currently cannot compile its test sources, and cannot
build a web bundle:
```
[ERROR] NotificationOutboxServiceTest.java:[484,20] method claimForDispatch
... cannot be applied to given types
[ERROR] NotificationOutboxServiceTest.java:[516,20] method claimForDispatch
... cannot be applied to given types
src/pages/ops/__tests__/auditRiskInsights.test.ts(193,23): error TS2322:
Type 'null' is not assignable to type 'string | undefined'.
```
## How each happened
**Backend.** #6494 added `expectedAttemptCount` to `claimForDispatch` (five
args → six). #6663 then
added two stubs written against the old five-argument signature. The two
changes touch different
lines, so `merge-tree` was clean for both and each merged on its own;
together they break
`mvn test-compile` for the whole module. The fix matches the six-argument
form this same file
already uses at lines 177, 245 and 276.
**Frontend.** The audit top-operator regression added in #6367 passed
`operator: null`, while
`AuditRecord.operator` is typed `string` (so `Partial<AuditRecord>` allows
`string | undefined`
only). `vitest` strips types without checking them, so the suite stayed
green while `tsc -b`
failed — and `npm run build` is `tsc -b && vite build`, so no bundle could
be produced.
`operator: undefined` exercises the same `normalizeText` / `?.trim()` path,
so the test's intent
is unchanged.
Neither break is caught by the current gates: this repository does not
require checks to merge,
`vitest` does not typecheck, and the backend failure only shows up at
`test-compile`.
## Verification
- `mvn -B -ntp test` (server module): see the follow-up comment — full run
recorded
- `npm run build`: exit 0 (tsc -b, vite build, and `license:check` all pass)
- `npx vitest run`: 160 files / 1734 tests green
- Mutation check still holds: reverting the `buildTopOperator` identity key
turns only the new
audit test red (1 failed / 15 passed)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
