iloveeyjafjalla commented on PR #6675:
URL:
https://github.com/apache/rocketmq-dashboard/pull/6675#issuecomment-6191712142
Addressed in `8440f6ce`:
- Rebased onto the current `rocketmq-studio` and re-landed the change on
`web/src/components/MessageQueryHistoryModal.tsx` and
`web/src/components/__tests__/MessageQueryHistoryModal.test.tsx`. The case I
extended is `renders query history modal copy in English mode`; the new case
sits next to it. "drawer" is gone from the title and the description.
- The type column now declares `width: 160`, room for `Query by Message
Key`, and the new case pins it (`expect(document.querySelector('.ant-table
colgroup col')).toHaveStyle({ width: '160px' })`) so a later shrink cannot
silently bring the wrap back.
Verification on the rebased head: `npx vitest run
src/components/__tests__/MessageQueryHistoryModal.test.tsx --maxWorkers=1` -> 9
passed; the same command with the component reverted -> 2 failed (cannot find
`Query by Message Key` / `按 Message Key`); `eslint` and `prettier --check`
clean on both files; `tsc -b` reports only the pre-existing `auditRiskInsights`
error, which #6732 fixes.
The optional consolidation is deliberately not part of this PR:
`web/src/pages/instance/message.tsx` has several open PRs in flight, and this
change stays with the three values the page already labels. If you would rather
have the mapping lifted into a shared helper, I can do that as a follow-up on
top of the merge.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
