zmuxuny opened a new pull request, #6758:
URL: https://github.com/apache/rocketmq-dashboard/pull/6758

   ### Which Issue(s) This PR Fixes
   
   Fixes #6751
   
   ### Brief Description
   
   An Add Instance request can finish after the operator cancels and reopens 
the custom dialog. Its unconditional completion cleanup closed the new session 
and discarded that later draft.
   
   Bind form cleanup to the session that submitted the creation. Cancel/reopen 
remain available; the already-sent create still completes and refreshes 
inventory, but cannot reset or close a subsequent draft. The normal edit dialog 
and create/import concurrency policy are unchanged.
   
   ### How Did You Test This Change?
   
   - Baseline a92c2314 real-component regression fails: submitting A, 
cancelling, opening/filling B, then resolving A makes the B dialog disappear. 
Normal edit control passes.
   - `cd web && npx vitest run 
src/pages/instance/__tests__/InstancePage.test.tsx --maxWorkers=1`: 39/39 pass, 
independently run.
   - Five new lifecycle cases: late success after Cancel or X, late failure, 
ordinary success cleanup, and cancelling without reopening while remote 
creation finishes. Test CSS motion is disabled only to avoid incomplete jsdom 
leave animation.
   - `NODE_OPTIONS=--max-old-space-size=1536 npm run build`: pass, including 
TypeScript and license check (132 actual components,139 license files).
   - Changed-file ESLint: zero errors/warnings; Prettier and diff-check pass.
   - Node24.19.0. Full frontend suite, live instance creation and Java tests 
not run locally.
   
   ### Checklist
   
   - [x] One coherent dialog lifecycle fix
   - [x] Conventional Commit subject
   - [x] Regression tests added
   - [x] No new strings, dependencies or source files
   
   AI-assisted implementation/testing, independently reviewed and verified.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to