messere1 commented on PR #6730:
URL: 
https://github.com/apache/rocketmq-dashboard/pull/6730#issuecomment-6196423031

   Closing this: #6735 repaired the same break test-side (the two `operator: 
null` fixtures in `auditRiskInsights.test.ts` became `undefined`), which keeps 
`AuditRecord.operator` a non-null `string` as the maintainers intended — the 
opposite resolution of the same pair, so keeping both would ask for the same 
fix twice.
   
   For the record, the break this was written against was real: `tsc -b` failed 
on the then-tip with TS2322 on those two rows, and every PR's Frontend Build 
went red through no fault of its own until #6735 landed. With the tip repaired 
this change is redundant — withdrawing it to keep the queue clean.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to