iloveeyjafjalla opened a new issue, #6842:
URL: https://github.com/apache/rocketmq-dashboard/issues/6842

   ### Studio Version
   
   branch: `rocketmq-studio` @ `a92c2314` (the revision this was verified on)
   
   ### Runtime Environment
   
   The repository's compose deployment, read from its own files — no live 
cluster needed: the defect is between `deploy/.env.example`, 
`deploy/docker-compose.yml` and `server/src/main/resources/application.yml`.
   
   ### Describe the Bug
   
   The deployment documents `STUDIO_AI_RMQCTL_TIMEOUT` in two places, and it 
does nothing:
   
   ```yaml
   # deploy/docker-compose.yml:82
   STUDIO_AI_RMQCTL_TIMEOUT: ${STUDIO_AI_RMQCTL_TIMEOUT:-PT60S}
   ```
   ```ini
   # deploy/.env.example:115
   # STUDIO_AI_RMQCTL_TIMEOUT=PT60S
   ```
   
   An operator who sets it (a slow or contended host wants a longer rmqctl call 
than 60 s) still gets 60 s.
   
   ### Root Cause
   
   The property the app binds is `studio.ai.conversation.rmqctl-timeout`, and 
`application.yml` spells it as a literal:
   
   ```yaml
   # server/src/main/resources/application.yml:125
         rmqctl-timeout: PT60S
   ```
   
   Its two direct neighbours in the same block carry the explicit bridge that 
makes their documented variables work:
   
   ```yaml
         rmqctl-enabled: ${STUDIO_AI_RMQCTL_ENABLED:true}
         rmqctl-server-url: ${STUDIO_AI_RMQCTL_SERVER_URL:}
         rmqctl-timeout: PT60S
   ```
   
   So the documented name maps to `studio.ai.rmqctl.timeout`, which neither 
`application.yml` nor any `@ConfigurationProperties` class provides 
(`AiConversationProperties` is bound to `studio.ai.conversation` and holds 
`rmqctlTimeout` there), while the value that actually reaches the tool is the 
literal: `RmqctlWorkspace` passes `properties.getRmqctlTimeout()` straight onto 
the rmqctl command line (`RmqctlWorkspace.java:428`).
   
   The three siblings are documented identically and only two of them are 
bridged, so this is an oversight rather than a deliberate fixed timeout.
   
   ### Expected Behavior
   
   Setting `STUDIO_AI_RMQCTL_TIMEOUT` in the deployment changes the timeout the 
AI conversation's rmqctl invocations use, exactly like 
`STUDIO_AI_RMQCTL_ENABLED` and `STUDIO_AI_RMQCTL_SERVER_URL` change theirs; the 
default stays 60 s.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to