pilichoumao opened a new pull request, #6883:
URL: https://github.com/apache/rocketmq-dashboard/pull/6883

   ### Which Issue(s) This PR Fixes
   
   Fixes #6881
   
   ### Brief Description
   
   A finite provider timestamp outside JavaScript Date's range made the metrics 
panel's CSV export throw RangeError, losing the entire download. Guard the 
derived ISO conversion and leave only `Timestamp ISO` empty for an 
unrepresentable date. Preserve the raw epoch, value, labels and 
scalar/histogram rows, including valid samples in the same response. Document 
the empty cell; no CSV fields or epoch units change.
   
   Related #5362 / #5789 guard general date formatters; #5726 concerns CSV 
epoch units. This change is limited to the direct conversion in the metrics 
exporter.
   
   ### How Did You Test This Change?
   
   On ECS Ubuntu Linux / Node 20.20.2, verified all 396 tracked Web source 
files against the branch manifest and reused dependencies with the identical 
committed lockfile:
   
   - Restoring the original exporter: 6 new utility regressions fail; 28 
controls pass.
   - Fixed exporter: the complete affected utility and MetricsExplorer 
component suites pass, 88/88, no skips. After adding required `warnings` fields 
to two new typed test fixtures, reverified the full manifest and reran the 
utility suite, 34/34.
   - Changed-file ESLint and Prettier pass.
   - `npm run license:test`: 5/5 pass.
   - `npm run build`: TypeScript, Vite and license gate pass (132 actual 
components / 139 license files).
   
   Tests cover scalar/histogram rows, mixed or only out-of-range dates, 
positive/negative Date boundaries, multiplication overflow, zero and fractional 
seconds. The initial build caught the missing test-fixture fields; the 
corrected final source builds successfully. No live Prometheus/Broker/MySQL or 
browser-layout claim is made for this formatter-only change.
   
   AI assistance was used to investigate, implement and verify the change.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to