Loyal-Young commented on PR #5384: URL: https://github.com/apache/rocketmq-dashboard/pull/5384#issuecomment-6232745083
Review follow-up: the current head now uses one settingsInFlightRef for all five settings writers, including appearance preference and security saves, and holds it through the notification test. The tests cover cross-card overlap in both directions and the errorFields early return releasing the guard. I updated the PR description to reflect those changes; the focused suite, TypeScript and ESLint passed. The remaining red CI job is the unrelated DLQ test timing noted above. Ready for re-review. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
