chstercc opened a new pull request, #6931: URL: https://github.com/apache/rocketmq-dashboard/pull/6931
### Which Issue(s) This PR Fixes - Fixes #6810 ### Brief Description `POST /api/settings/general/save` answers `Result<Void>` and never echoes the signing secret back, so `GeneralSettingsTab` maintains `dingtalkSigningSecretConfigured` locally. `mergeAndSave` built the new snapshot from the fresh read taken *before* the write, whose flag is still `false`, and the submitted form values carry no flag — so saving a secret left the flag `false` and the "清除钉钉签名密钥" control hidden until a reload. Mark a non-empty `dingtalkSigningSecret` in the patch as configured when the save succeeds. The clear path already carries `dingtalkSigningSecretConfigured: false` in its own patch, so it is unaffected. ### How Did You Test This Change? - `cd web && npx vitest run src/pages/settings/__tests__/GeneralSettingsTab.test.tsx` — 9 passed. The new regression fails on the parent commit (`Unable to find an element with the text: 清除钉钉签名密钥`) and passes after the change. - `cd web && npm test` — 1763 passed, 0 failed. - `cd web && npm run lint` — 0 errors (10 pre-existing warnings). - `cd web && npm run build` — passed, including the license check. The regression asserts on the button text rather than its role: immediately after the save, antd's loading icon is still animating out in jsdom and contributes `aria-label="loading"` to the accessible name of the button. ### Checklist - [x] One coherent change; unrelated modifications are not bundled in - [x] Commit subject follows Conventional Commits (`fix:`) - [x] Tests added or updated for non-trivial changes - [x] New UI text has both Chinese and English entries under `web/src/i18n/` (no new UI text) - [x] Architecture constraints stay green (no backend change) - [x] New source files carry the ASF license header (no new source files) - [x] Documentation touched where behaviour changed (no user-facing docs needed) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
