iloveeyjafjalla opened a new pull request, #6935: URL: https://github.com/apache/rocketmq-dashboard/pull/6935
Fixes #6934 ## The defect `findFilterOptions` caches the four dropdown lists for 30 seconds; `save` invalidates that cache and `deleteBefore` (Cleanup) did not. The page's post-cleanup refetch could therefore be answered from the cache and keep offering a value whose rows were just deleted. ## The fix A cleanup that deleted anything drops the cache, mirroring `save`. No-op cleanups leave it alone. ## Tests Red before the change (`deleteBeforeInvalidatesCachedFilterOptionsTest` asserts the mapper is reached again after the cleanup): ``` [ERROR] MybatisPlusAuditRepositoryTest.deleteBeforeInvalidatesCachedFilterOptionsTest:213 ``` Green after: ``` Tests run: 13, Failures: 0, Errors: 0 -- MybatisPlusAuditRepositoryTest Tests run: 19, Failures: 0, Errors: 0 -- AuditServiceTest [INFO] You have 0 Checkstyle violations. ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
