iloveeyjafjalla opened a new pull request, #6941: URL: https://github.com/apache/rocketmq-dashboard/pull/6941
Fixes #6940 ## The defect `listAlertRuleRuntime(...).catch(() => undefined)` discarded the failure, and the runtime column renders 未采集 for any rule without a runtime row — so a failed read asserted that every rule's collection is off, and a failed refresh left stale firing/pending states in place. ## The fix The failure is state: the previous values are dropped (they describe a different read), the column renders `-` with `alerts.runtimeLoadFailed` as its title/aria-label, and a successful empty read keeps the honest 未采集. ## Tests Red before the change (`未采集` present after a rejected runtime read), green after with the whole page suite: ``` Tests 38 passed (38) (AlertsPage.test.tsx) tsc -b exit 0 eslint exit 0 (five pre-existing warnings in alerts.tsx) prettier --check All matched files use Prettier code style! ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
