iloveeyjafjalla opened a new pull request, #6943:
URL: https://github.com/apache/rocketmq-dashboard/pull/6943

   Fixes #6942
   
   ## The defect
   
   `rmqctl` resolves its config as `--config` > `RMQCTL_CONFIG` > 
`~/.rmqctl/config.yaml`, but `mcp config` only mirrored the flag. With the 
environment variable set, the emitted snippet started `rmqctl mcp stdio` with 
no `--config`, and a GUI-launched MCP client inherits no shell environment — so 
the child resolved the default file instead of the selected one.
   
   ## The fix
   
   The snippet now carries the file the invocation actually selected: the 
explicit flag first, then `RMQCTL_CONFIG`, resolved to an absolute path like 
the flag branch already was. The pinned behaviour for "neither given" is 
unchanged (no `--config`).
   
   ## Tests
   
   Red before the change:
   
   ```
   --- FAIL: TestMCPConfigCarriesTheEnvironmentSelectedPath
       args = ["mcp" "stdio"]; want the selected config [.../env/selected.yaml]
   ```
   
   Green after: `go test ./...` all packages ok, `gofmt -l` clean, 
`catalog-verify` exit 0.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to