iloveeyjafjalla opened a new pull request, #6945:
URL: https://github.com/apache/rocketmq-dashboard/pull/6945

   Fixes #6944
   
   ## The defect
   
   `rmq.group.update`'s create branch forwarded `subscriptionDataType=FIFO` 
without the order type the console always sends, so the broker group was 
configured with `consumeMessageOrderly=false` while the tool reported success.
   
   ## The fix
   
   Both the preview and the execute path derive the console's default when the 
caller names FIFO and no order type: `deliveryOrderType = PARTITON_ORDER`. An 
explicit value is never overridden, and a non-FIFO create is untouched.
   
   ## Tests
   
   Red before the change 
(`updateCreatesAFifoGroupWithTheConsolesDefaultOrderTypeTest` captures the 
created VO and expects the derived order type):
   
   ```
   [ERROR] 
GroupMutationPlanTest.updateCreatesAFifoGroupWithTheConsolesDefaultOrderTypeTest:163
   ```
   
   Green after:
   
   ```
   Tests run: 5, Failures: 0, Errors: 0 -- GroupMutationPlanTest
   [INFO] You have 0 Checkstyle violations.
   ```
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to