iloveeyjafjalla opened a new pull request, #7015:
URL: https://github.com/apache/rocketmq-dashboard/pull/7015

   Fixes #7014
   
   ## The defect
   
   `rmq.group.update` advertised `delaySeconds` as writable. Nothing applies it 
— the broker config has no delay field, the provider's update path writes only 
the retry limit, and persistence has no delay column — so a call that included 
it returned `EXECUTED` while the value was discarded.
   
   ## The fix
   
   The input schema no longer declares `delaySeconds`, so a call that tries to 
set it is rejected by the tool-schema validation every call goes through (the 
property schema is `additionalProperties: false`). `GroupInput` keeps the field 
for the plan's read-only display, and `rmq.group.detail` keeps reporting the 
measured delay; the generated CLI catalog is regenerated (the `group update` 
command loses the flag).
   
   ## Tests
   
   Red before the change:
   
   ```
   
ToolCatalogTest.rejectsDelaySecondsOnGroupUpdateBecauseNothingAppliesItTest:121
   Expecting code to raise a throwable.
   ```
   
   Green after:
   
   ```
   Tests run: 9 -- ToolCatalogTest       Tests run: 2 -- 
ToolOutputSchemaContractTest
   [INFO] You have 0 Checkstyle violations.
   go test ./... ok      gofmt clean      catalog-verify exit 0
   ```
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to