iloveeyjafjalla opened a new pull request, #7033:
URL: https://github.com/apache/rocketmq-dashboard/pull/7033

   Fixes #7032
   
   ## The defect
   
   `toTopicConsumer` derived the contract's `consumeType` 
(CLUSTERING/BROADCASTING) from Tencent's `ConsumeType`, which reports the 
consumption mechanism (PUSH/PULL/POP). The mapper only recognises 
BROADCAST/CLUSTER, so every Tencent topic consumer carried `consumeType: null` 
while its `messageModel` said CLUSTERING — in the console table and in the AI 
topic-detail projection.
   
   ## The fix
   
   The projection reads `MessageModel` first and keeps the mechanism as the 
fallback, the same rule the Apache and Aliyun paths use. One call-site change 
plus a comment explaining the vendor's field semantics.
   
   ## Tests
   
   Red before the change:
   
   ```
   expected: CLUSTERING
    but was: null
   ```
   
   Green after:
   
   ```
   Tests run: 64 -- TencentInstanceProviderTest     Tests run: 10 -- 
AliyunConvertersTest
   [INFO] You have 0 Checkstyle violations.
   ```
   
   The new case stubs `ConsumeType("PUSH")` + `MessageModel("CLUSTERING")` — 
the vendor's real shape — and pins both the derived `consumeType` and the model 
beside it; the existing `getTopicConsumersShouldMapSubscriptionsTest` keeps its 
meaning.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to