123123213weqw opened a new pull request, #7054:
URL: https://github.com/apache/rocketmq-dashboard/pull/7054

   Fixes #6462.
   
   The MetricsExplorer scope-fallback effect scheduled its data-source reset 
through a zero-delay `window.setTimeout` whose id was never captured, so the 
pending callback survived effect cleanup — an unmount, or the scope changing 
away and back before the timer ran, still reset the source/credentials and 
re-issued queries under the abandoned scope.
   
   The timer id is now captured and cleared by the effect's cleanup: any re-run 
(scope change) or unmount cancels the pending fallback, while the intended 
fallback (leaving the instance scope with no selection) is unchanged.
   
   Two red-first component regressions: unmount before the timer executes 
produces no reset and no extra query, and leaving-then-returning before it 
executes keeps the restored source selected with the reload routed through the 
original instance's data source — both fail on the old code. Suite is 54/54.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to