123123213weqw opened a new pull request, #7058: URL: https://github.com/apache/rocketmq-dashboard/pull/7058
Fixes #6410 and fixes #6406. Both defects live in `clientConnectionDiagnostics.ts` and shared one root: the diagnostics treated independently-clustered and partially-unknown inventory as if it were one fully-observed pool. ## #6410 — cluster inventories pooled together The resource key, connection identity and client-ID grouping all omitted `clusterName`, so rows from independent physical clusters collapsed into one bucket: row keys collided across clusters (breaking the table), client-ID "collisions" were counted across unrelated clusters, and address concentration was judged on a mixed pool. Resource and connection identities are now cluster-scoped tuples (keeping #6303's tuple encoding — no delimiter concatenation), client grouping keys on `(cluster, clientId)`, concentration is judged per cluster, the summary counts distinct `(cluster, value)` pairs, and the diagnostics tables gained a Cluster column (reusing the existing `clients.cluster` key). ## #6406 — facts inferred from unknown results Mixed-protocol/version/language checks counted `null` proxy metadata as an observed `'unknown'` dimension and treated a missing value as a reported one, and `SINGLE_CONSUMER_INSTANCE` fired off an incomplete scan. Checks now run only over genuinely reported (non-empty) fields, `null` metadata no longer manufactures an `'unknown'` observation, single-consumer requires a complete scan, and the `PARTIAL_CONNECTION_SCAN` wording covers incomplete Consumer queries. Unknown-metadata and partial-scan warnings stay visible; genuinely mixed dimensions keep their diagnostics. ## Tests 13 new cases (7 cluster-scoping, 6 unknown-result, including 2 controls that must keep their diagnostics), verified red-first on v100: exactly the 11 defect cases failed before the fix. Targeted suite 21/21; the full web suite is green at 161 files / 1816 tests; lint and `tsc -b` clean. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
