unbridled-41 commented on PR #5430: URL: https://github.com/apache/rocketmq-dashboard/pull/5430#issuecomment-6267639520
Thanks for the review — all three blockers (and the javadoc note) are fixed in 8ab86d71: 1. **Test suffix** — the four `LikePatternsTest` methods now end in `Test` (`escapesEveryLikeMetacharacterTest`, `escapesTheEscapeCharacterItselfTest`, `leavesPlainTextAloneTest`, `passesAbsentFiltersThroughTest`). 2. **Remaining call sites** — all of them are routed through `LikePatterns.escape`: `RocketMQMetadataProvider` topic/group search (the four sites), `MybatisPlusInstanceRepository.search`/`findByTypeAndSearch` (name/endpoint/remark), `MybatisPlusAlertRepository` rule name/metric search, `MybatisPlusCloudCredentialRepository` name search, and the `type` fragment spliced into `MybatisPlusSettingsRepository`'s `CONCAT` pattern. Each path has a regression test asserting the bound parameter (`%topic\_a%`, etc.). 3. **`AuthService` username search** — covered by `AuthServiceDatabaseTest`, mirroring the audit-repository test and asserting the escaped bound parameter. 4. **Stale javadoc** — the "no shared SqlLikeUtils" note in `AiTimelineRepositoryTest` is removed. Re-verified on the current head `30ac7cc7` (base merged): `LikePatternsTest` 4, `MybatisPlusAuditRepositoryTest` 13, `MybatisPlusAclRepositoryTest` 28, `MybatisPlusSettingsRepositoryTest` 12, `QueryHistoryServiceTest` 14, `MybatisPlusInstanceRepositoryTest` 22, `MybatisPlusAlertRepositoryTest` 20, `MybatisPlusCloudCredentialRepositoryTest` 9, `RocketMQMetadataProviderTest` 56, `AuthServiceDatabaseTest` 31, `AiTimelineRepositoryTest` 35 — 0 failures. Checkstyle clean. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
