lizhimins opened a new pull request, #7081:
URL: https://github.com/apache/rocketmq-dashboard/pull/7081
## What
Adds the required `resourceType` to the `listAclRules` fixture in the
"renders creation times in the
viewer timezone from the offset-less UTC wire format" case of
`AclPage.test.tsx`.
## Why
#6686 introduced that fixture without `resourceType`, which `AclRule`
(web/src/api/acl.ts:17)
requires. `vitest` transpiles without type checking, so the suite stayed
green (35/35 in that file,
1831 overall), but `tsc -b` — the frontend build gate in `ci.yml` — failed
once the change landed on
`rocketmq-studio`:
```
src/pages/instance/__tests__/AclPage.test.tsx(261,11): error TS2741:
Property 'resourceType' is
missing in type '{ id: number; principal: string; ... }' but required in
type 'AclRule'.
```
The value follows the file's existing convention (`resourceType: 'Topic'`
for a topic resource).
## Verification
- `npx tsc -b --force` — clean (was one error).
- `npx vitest run src/pages/instance/__tests__/AclPage.test.tsx` — 35/35
green.
- Full trunk verification at `feb96cbea`: backend `mvn test
-Dspring.profiles.active=dev` 3830/3830,
frontend `npm run lint` 0 errors (10 pre-existing warnings), `npm test`
1831/1831.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
