zmuxuny opened a new pull request, #7150: URL: https://github.com/apache/rocketmq-dashboard/pull/7150
### Which Issue(s) This PR Fixes - Fixes #7149 ### Brief Description Give both instance inventory filters accessible names using the existing English/Chinese translations. The search placeholder and selected access type currently leave the real textbox and combobox unnamed. The regression tests render the real AntD controls in both languages and cover their names, keyboard type selection, combined search/type filtering, and clearing the search while retaining the selected type. ### How Did You Test This Change? Before the production change, both language cases failed on all four accessible-name assertions. Their keyboard and filtering checks passed. With the two labels added: ```sh cd web npx vitest run src/pages/instance/__tests__/InstancePage.test.tsx src/services/instanceService.test.ts src/i18n/__tests__/translations.test.ts src/i18n/__tests__/LangContext.test.tsx src/i18n/languagePreference.test.ts --pool=threads --maxWorkers=1 # 5 files passed, 62 tests passed npx tsc -b --force npx eslint src/pages/instance/index.tsx src/pages/instance/__tests__/InstancePage.test.tsx npx prettier --check src/pages/instance/index.tsx src/pages/instance/__tests__/InstancePage.test.tsx git diff --check # All passed ``` ### Checklist - [x] One coherent change; unrelated modifications are not bundled in - [x] Commit subject follows Conventional Commits - [x] Regression tests added with `...Test` names - [x] Existing English and Chinese translations reused; no new UI text - [ ] Architecture tests not run for this frontend-only change; no backend files changed - [x] No new source files; existing ASF headers retained - [x] No documented behavior changed Base branch: `rocketmq-studio`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
