zmuxuny opened a new pull request, #7167:
URL: https://github.com/apache/rocketmq-dashboard/pull/7167

   ### Which Issue(s) This PR Fixes
   
   Fixes #7166.
   
   ### Brief Description
   
   The Topic send-message form renders custom-property removal as a clickable 
icon without keyboard semantics. A keyboard user can add properties but cannot 
tab to the removal action to repair the draft, including removing a duplicate 
key that blocks sending.
   
   Use an Ant Design text button with the existing icon and removal callback, 
an explicit non-submit type, and an English/Chinese accessible name containing 
the current row number. Keep the pointer action and retained property values 
unchanged. No send-message API, payload validation, or surrounding dialog 
translation changes.
   
   ### How Did You Test This Change?
   
   Base: `rocketmq-studio@127c47b06a268cc74224d5f34c56ec7c36ac0d55`.
   
   - The exact same final test file on unchanged production: **4 keyboard 
regressions fail, 1 pointer control passes**.
   - Fixed related suites: **75 tests across 4 files pass** (TopicPage, 
messageProperties, messagePayloadPreview, translation dictionary).
   - The four new cases cover English/Chinese and Enter/Space. Fixture values 
use `fireEvent.change`; real `userEvent.tab` moves from the middle value to the 
named removal button, and `userEvent.keyboard` removes that row. They verify 
the two retained values, row-label renumbering, no form-submit event and no 
send request during removal, then explicitly send and assert the exact retained 
properties. The pointer control remains green.
   - Forced TypeScript build-mode check (`tsc -b --force`), ESLint and Prettier 
for all three changed files, and `git diff --check`: pass.
   
   Tests ran sequentially with one worker and file parallelism disabled. No 
full-repository test run, production build or deployed-browser test is claimed. 
English coverage concerns the new removal-action name; the existing surrounding 
dialog text is unchanged.
   
   AI assistance was used for investigation, implementation and validation. A 
separate automated review checked the actual diff and regression evidence; no 
human or maintainer approval is claimed.
   
   ### Checklist
   
   - [x] One coherent keyboard-accessibility fix with regression and pointer 
controls
   - [x] New user-visible wording provided in English and Chinese
   - [x] Conventional Commit subject and existing test conventions
   - [ ] Full repository integration suite not run
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to