Kris20030907 commented on issue #6643:
URL:
https://github.com/apache/rocketmq-dashboard/issues/6643#issuecomment-6266574225
Thanks — both corrections are right, and I've verified them on the current
tree: the generic dialog already creates a LITE parent through the type picker
and `applyTopicType`, and the 5.5.0 jars we compile against do expose
`TopicConfig#setLiteTopicExpiration(int)` and
`SubscriptionGroupConfig#setLiteBindTopic(String)`. Taking the three
recommendations as decided:
1. **ttlMinutes on create** — range 1..43200, minutes, default 1440; `<= 0`
("never expire") is not exposed. `extendTTL` keeps its current API for
compatibility and the unit difference will be documented.
2. **Reuse the topic create path** — I'll rework #6644 to add an optional
`liteTtlMinutes` to `CreateTopicDTO`/`TopicVO` (valid only with `type=LITE`,
`$` rejected in the name), set it via `setLiteTopicExpiration` in
`createTopic`, show a TTL input in the create dialog when LITE is selected, and
add a "Create Lite parent" button on the LiteTopic page that opens the same
dialog with LITE preselected. The dedicated write path from #6644 goes away.
3. **Group binding stays slice 3** — an optional step in the same onboarding
flow, `liteBindTopic` via `SubscriptionGroupConfig#setLiteBindTopic`, with the
parent validated as an owned LITE topic and partial failures reported
explicitly.
Before the create-time TTL lands I'll also add the regression test you
flagged: the update path's preflight + empty delta + `message.type` re-apply
must not clobber `lite.topic.expiration`. Slice 2 (delete with the child-count
blast radius and the note that bound consumer groups are not deleted) and slice
3 will follow as separate PRs. Per-child LMQ deletion stays out of scope.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
