zmuxuny opened a new pull request, #7104:
URL: https://github.com/apache/rocketmq-dashboard/pull/7104

   ### Which Issue(s) This PR Fixes
   
   Fixes #7098
   
   ### Brief Description
   
   Give the queue-browser topic picker an accessible name and identify each 
offset slider and message-detail close button by its queue. The current 
combobox and sliders have no names, while every close icon has the same generic 
name. Multiple brokers/queues are therefore indistinguishable through these 
controls in assistive technology.
   
   - Reuse the localized topic placeholder as the combobox name.
   - Use Ant Design's handle-specific ARIA property to label the actual slider 
handle with broker and queue.
   - Add Chinese and English close-detail labels containing the queue key.
   - Exercise real controls in both locales, distinguish two broker sliders, 
change an offset with ArrowLeft, and close its detail with Enter.
   
   ### How Did You Test This Change?
   
   Fail-before tests on `rocketmq-studio@127c47b0` identified the unnamed 
combobox/slider and missing queue-specific close name in both locales. The 
existing request-ownership test now uses the real language provider so 
interpolated labels match the application.
   
   From `web/`:
   
   ```sh
   npx vitest run src/components/__tests__/QueueBrowser.test.tsx src/i18n 
--pool=threads --maxWorkers=1
   # 4 files, 33 tests passed
   npx tsc -b
   npx eslint src/components/QueueBrowser.tsx 
src/components/__tests__/QueueBrowser.test.tsx src/i18n/translations.ts
   npx prettier --check src/components/QueueBrowser.tsx 
src/components/__tests__/QueueBrowser.test.tsx src/i18n/translations.ts
   ```
   
   Type-checking, formatting and `git diff --check` pass. ESLint reports no 
errors and one existing fast-refresh warning in QueueBrowser.tsx. Independent 
diff review passed. No live broker or manual screen-reader session was used; 
names and keyboard behavior are asserted using the rendered accessibility tree 
and DOM events. No backend code or dependencies changed.
   
   AI assistance was used for investigation, implementation, regression tests 
and independent review.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to