zmuxuny opened a new pull request, #7178:
URL: https://github.com/apache/rocketmq-dashboard/pull/7178

   ### Which Issue(s) This PR Fixes
   
   Fixes #7177
   
   ### Brief Description
   
   Only show Clients diagnostics after the current endpoint/cluster/type 
inventory has been read successfully. The initial or cleared empty array 
currently produces a critical 76/100 no-clients diagnosis during loading, after 
API failure, and with no registered nameserver.
   
   Track the successful query key, clear it when a new read starts, and gate 
the diagnostic panel. Clearing the marker also prevents registry loading 
finishing first from reviving an earlier same-query diagnosis during retry. 
Successful empty responses retain the existing critical diagnosis. The 
diagnostic algorithm is unchanged.
   
   This is separate from #7058, which changes grouping/metadata/partial-scan 
semantics. No backend or API changes; two existing frontend files only.
   
   ### How Did You Test This Change?
   
   - Nine real-AntD regression cases: pending registry/connections, failed 
reads and recovery, missing endpoints, all three query-scope changes, and a 
registry-first retry returning to an earlier successful scope. Exact final test 
cases against unmodified production: 8 fail, 1 successful-empty control passes.
   - Related Clients, diagnostics and filter tests: 55 passed across 5 files 
using one Vitest worker.
   - Forced TypeScript project build, ESLint and Prettier for the two changed 
files, and git diff --check passed.
   - Independent review of the final commit found no blocking issue.
   
   No full frontend suite, bundle build, backend tests or live-cluster 
validation was run.
   
   ### Checklist
   
   - [x] One coherent change; no unrelated modifications
   - [x] Conventional commit subject
   - [x] Non-trivial changes covered by regression tests
   - [x] No new UI strings, source files or dependencies
   - [x] Frontend-only; backend architecture unchanged
   
   Commands (from web, NODE_OPTIONS=--max-old-space-size=768):
   
   ```text
   node node_modules/vitest/vitest.mjs run 
src/pages/cluster/__tests__/ClientsPage.test.tsx 
src/pages/cluster/__tests__/clientsSearch.test.ts 
src/utils/clientConnectionDiagnostics.test.ts 
src/services/connectionsService.test.ts src/api/connections.test.ts 
--maxWorkers=1
   node node_modules/typescript/bin/tsc -b --force
   node node_modules/eslint/bin/eslint.js src/pages/cluster/clients.tsx 
src/pages/cluster/__tests__/ClientsPage.test.tsx
   node node_modules/prettier/bin/prettier.cjs --check 
src/pages/cluster/clients.tsx src/pages/cluster/__tests__/ClientsPage.test.tsx
   ```
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to