PrithwishDas101 commented on issue #7149: URL: https://github.com/apache/rocketmq-dashboard/issues/7149#issuecomment-6272962217
The fix can stay localized to the Instance Management filter bar and reuse the existing translations. I'd suggest: 1. Give the search `Input` a stable accessible name using an appropriate translated label or `aria-label`, rather than relying on its placeholder alone. 2. Give the access-type `Select` its own translated accessible name, such as the existing `instance.accessType` string. 3. Add regression tests to `InstancePage.test.tsx` that render the real controls in both English and Chinese and assert their accessible names with `toHaveAccessibleName()`. 4. Verify that the search input retains its accessible name after typing, and that selecting an access type doesn't change the dropdown's name or break existing filtering behavior. The important detail is to test the controls' accessible names, not just their visible placeholders. This should be a focused accessibility fix without changing the filter requests or UI behavior. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
