zmuxuny opened a new pull request, #7163: URL: https://github.com/apache/rocketmq-dashboard/pull/7163
### What does this PR do? Fixes #7162. Give the real searchable combobox in the shared `InstanceSelect` an accessible name using the same existing translated/caller-provided prompt as its visible placeholder. This shared selector appears in Message, Topic, DLQ, ACL and Consumer; none of those five call sites supplies an external label. The production change is one `aria-label` prop. Search, selection, clearing, error/retry rendering and the visible placeholder are unchanged. No new translation keys or dependency changes. ### Why is this change needed? Ant Design's visible placeholder and selected option do not name its search input. The control therefore has an empty accessible name even with an instance selected. The gap also affects an explicit caller prompt and the failed-instance-list UI. ### Tests - The exact same four new tests fail on unchanged production code (four existing component tests still pass). - With the fix, 19 tests in four files pass: the real `InstanceSelect` suite and existing language-context, translation and language-preference suites. - New cases verify selected-value Chinese/English names, an explicit caller prompt and the failed-list state through role/name queries against the real Ant Design control. - Forced TypeScript project build, changed-file ESLint and Prettier checks, and `git diff --check` pass. - This is focused React Testing Library/jsdom validation. No manual screen-reader, live-cluster, backend or full-frontend-suite run is claimed. ### Scope / related work #3235/#3062 and #3762 cover visible placeholder localization/tests, #2786/#2874 search normalization, and #6348 failed list loading. #7150 labels separate instance-inventory search/access-type controls; it does not modify this shared component. This PR fixes the common component once rather than splitting its five callers. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
