zmuxuny opened a new pull request, #7215:
URL: https://github.com/apache/rocketmq-dashboard/pull/7215

   ### Which Issue(s) This PR Fixes
   
   Fixes #7214
   
   ### Brief Description
   
   Invalidate the Topic configuration comparison's request generation when its 
component unmounts. TopicPage conditionally mounts this modal, so Close or 
leaving the page must also end ownership of its pending read outcomes. 
Otherwise a rejected inventory read displays a global failure notification over 
the page the operator is now using.
   
   This adds disposal cleanup to the existing generation guard. The existing 
instance-pair invalidation from #4585 / #4586 is preserved. No API, inventory 
comparison, export, request cancellation or backend behavior changes.
   
   ### How Did You Test This Change?
   
   Added four real-component cases: source failure after unmount, target 
failure after unmount, an old failure after reopening and completing a new 
comparison, and a still-current failure under React StrictMode.
   
   On unchanged production at 127c47b06a268cc74224d5f34c56ec7c36ac0d55, the 
three abandoned-comparison cases fail and all 12 other cases pass. With the fix:
   
   - TopicConfigComparisonModal and topicConfigComparison suites: 26 tests pass.
   - Forced TypeScript build: passed.
   - Changed-file ESLint and Prettier: passed.
   - Production build and artifact license check: Passed (132 components, 139 
license files).
   
   No live cluster was used. The inventory service promises are controlled; 
AntD and the comparison component are real. Full frontend/backend suites were 
not run locally; remote CI will be checked on the published commit. Independent 
diff review: Approved; independently reran the focused 15-case component suite.
   
   ### Checklist
   
   - [x] Single coherent fix with regressions; existing assertions retained.
   - [x] Conventional Commit and DCO sign-off.
   - [x] No new UI strings, dependencies or source files.
   - [x] AI assistance disclosed.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to