The GitHub Actions job "CI" on rocketmq-dashboard.git/codex/acl-push-scope has 
failed.
Run started by GitHub user iloveeyjafjalla (triggered by iloveeyjafjalla).

Head commit for run:
ae32457bc203230c5226535409a69a8e62858d4f / iloveeyjafjalla <[email protected]>
fix(acl): scope the broker push to the instance's cluster

pushAclToBroker wrote every stored account and policy to every master behind the
instance's endpoint, while the rules view of the same page reads only the 
brokers of the
instance's configured cluster (#6502). On a NameServer shared by several 
clusters the two
paths disagreed: the page showed one cluster's rules and the push installed the 
dashboard's
accounts and policies on another cluster's brokers, reporting those upserts as 
successes.
The pre-flight ACL 2.0 switch check read the configuration of an arbitrary 
broker from that
unscoped list as well.

The scope now lives in one place, AclBrokerScope, which both the read and the 
push resolve
their broker set through: an instance bound to one cluster cannot touch another 
cluster's
brokers, an instance that names no cluster keeps every master of the endpoint, 
and an
unresolvable cluster membership fails closed (503) instead of falling back to 
the whole
cluster table. The push's broker order becomes the cluster's name order instead 
of a
hash-table order, so the pre-flight broker it checks is deterministic.

Report URL: 
https://github.com/apache/rocketmq-dashboard/actions/runs/39387539482

With regards,
GitHub Actions via GitBox

Reply via email to