The GitHub Actions job "CI" on 
rocketmq-dashboard.git/rz/alert-export-no-fabrication has succeeded.
Run started by GitHub user zjncs (triggered by zjncs).

Head commit for run:
17de7148749dda3b50d8694f72887a044dc09657 / Zhao Jianing <[email protected]>
fix(alert): stop fabricating export fields for invalid rules

The Prometheus export silently rewrote rules it could not express: a blank
duration became `for: 5m` even though Studio's own evaluation parses blank as
Duration.ZERO, an invalid metric became rocketmq_consumer_lag_messages, and an
invalid operator became ">". The downloaded rules file therefore described
alerts that fire on different metrics, comparisons, and schedules than the
rules shown on screen.

Mirror the export's existing precedent for unexportable native metrics: the
loop now skips a rule whose metric is not a valid Prometheus name or whose
operator is not supported, appending a comment that names the stored value. A
blank duration exports without a `for` clause so the alert fires immediately,
matching its on-screen Duration.ZERO semantics; legacy unordered durations keep
their historical 5m fallback. The expression builder now consumes the already
validated metric and operator instead of carrying the silent substitutions.

Signed-off-by: zjncs <[email protected]>

Report URL: 
https://github.com/apache/rocketmq-dashboard/actions/runs/39406767694

With regards,
GitHub Actions via GitBox

Reply via email to