X-LightYear opened a new pull request, #7295:
URL: https://github.com/apache/rocketmq-dashboard/pull/7295

   ## Summary
   
   - require one message identifier in the `rmq.message.query` MCP input schema
   - keep the existing `msgId` → `uniqueKey` → `key` dispatch precedence
   - regenerate the rmqctl catalog and add runtime schema regression coverage
   
   ## Problem
   
   The catalog required only `instanceId` and `topicName`, although 
`MessageQueryToolHandler` rejects requests unless at least one of `msgId`, 
`uniqueKey`, or `key` is non-empty. This allowed invalid requests to pass 
schema validation and fail later in handler execution.
   
   ## Fix
   
   Add an `anyOf` requirement for `msgId`, `uniqueKey`, or `key`. This aligns 
the MCP/runtime schema with the existing handler contract without changing 
query behavior.
   
   ## Testing
   
   - pre-fix deterministic regression failed because the invalid input was 
accepted
   - post-fix 
`ToolCatalogTest,MessageQueryToolHandlerTest,ToolOutputSchemaContractTest`: 18 
passed
   - rmqctl catalog tests: passed
   - checkstyle: 0 violations
   - `git diff --check`: passed
   
   Fixes #7294


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to