RockteMQ-AI commented on PR #1404: URL: https://github.com/apache/rocketmq-clients/pull/1404#issuecomment-6309310351
**Issue Evaluation** Category: `type/bug` | Status: **Confirmed** (5 of 6 claims verified against current codebase) Code verification results: | # | Claim | Verdict | Evidence | |---|-------|---------|----------| | 1 | `sync_settings` uses shadow clone | **Not found** | The function is `update_settings` (session.rs:388); `shadow_session()` exists (session.rs:132) but is not called from settings sync path | | 2 | Session map never evicts dead endpoints | **Verified** | Insert at client.rs:897, no removal during operation; only `clear()` on full shutdown (client.rs:910) | | 3 | No HTTP/2 keep-alive | **Verified** | `build_endpoint` (session.rs:225-226) sets only `connect_timeout` and `tcp_nodelay`; no `keep_alive`/`http2_keep_alive_interval` config | | 4 | No re-registration after failover (40015/50001) | **Verified** | No caller branches on these codes; only generic 30s heartbeat loop (client.rs:211-257) | | 5 | SimpleConsumer discards server-pushed settings | **Verified** | simple_consumer.rs:105 logs warning and drops the command | | 6 | `unwrap()` on session lookup can panic | **Verified** | 5 calls at client.rs:477, 489, 529, 603, 646 | **Severity:** High — issues #2-#6 affect production stability during server rolling deployments and failover scenarios. **Note:** The issue description references specific commits (`74ccc3a6` etc.) on a fix branch. If a PR is available, it would be helpful to link it for maintainer review. --- *Automated evaluation by RockteMQ-AI* -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
