Felix-Gong commented on PR #11475:
URL: https://github.com/apache/rocketmq/pull/11475#issuecomment-6330499667

   Hi @RongtongJin @lizhimins — this PR (and the two related fixes in the same 
area, #11469 and #11471) has been sitting with `action_required` since it was 
opened, so the workflows have never actually run on it. Could you approve the 
workflow when you get a chance?
   
   I've run the full `proxy` module locally with checkstyle and spotbugs 
enabled — 465 tests green — so I expect the checks to pass, and I'm happy to 
fix anything they flag.
   
   For context: this adds OpenTelemetry call metrics for the admin gRPC server 
(`rocketmq_proxy_admin_calls_total` and `rocketmq_proxy_admin_rt`, recorded by 
a new interceptor), so the control plane stops being the only invisible surface 
in the metrics pipeline. The AI review already came back green.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to