This is an automated email from the ASF dual-hosted git repository.
lizhimins pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/rocketmq-clients.git
The following commit(s) were added to refs/heads/master by this push:
new 7b0e26cf [ISSUE #1412] [CI] Stop gating build-result on the Rust build
(#1442)
7b0e26cf is described below
commit 7b0e26cf665e120eec9155d3259c0b17e8aa8544
Author: lizhimins <[email protected]>
AuthorDate: Fri Oct 23 05:55:55 2026 +0800
[ISSUE #1412] [CI] Stop gating build-result on the Rust build (#1442)
`build-result` is the required status check on master, and it aggregates
`rust-build`. That gates every Rust PR on a Rust baseline which is
currently red for reasons unrelated to any open change:
- rust/Cargo.lock is gitignored, so each run resolves dependencies from
scratch and now pulls hyper-util >= 0.1.16 (edition 2024, needs
rustc >= 1.85) and powerfmt >= 0.2.1 (needs rustc >= 1.79). Both break
the 1.74 toolchain that the `msrv` and `build` jobs install.
- Stable clippy fails on two pre-existing `for_kv_map` warnings in
rust/src/client.rs (lines 904 and 912), which `-D warnings` turns into
errors.
Since `build` declares `needs: [fmt, msrv]`, an msrv failure skips the
whole Ubuntu/macOS/Windows matrix, and `build-result` then blocks every
Rust PR whose head does not carry the dependency pins.
Drop `rust-build` from `needs` and from the aggregation script.
`rust_build.yml` is untouched: every Rust job still runs and still
reports its true result, so the signal stays visible on the PR -- it just
no longer gates the merge. Reviewers of Rust changes need to read
`rust-build / *` directly until this is reverted.
Restore `rust-build` here once the dependency pins (powerfmt < 0.2.1,
hyper-util < 0.1.16, tokio < 1.47) and the `for_kv_map` fix land on
master. #1404 contains both and is green.
---
.github/workflows/build.yml | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml
index 1dacbf97..6f7d4880 100644
--- a/.github/workflows/build.yml
+++ b/.github/workflows/build.yml
@@ -148,7 +148,7 @@ jobs:
uses: ./.github/workflows/nodejs_build.yml
build-result:
runs-on: ubuntu-latest
- needs: [java-build, cpp-build, csharp-build, golang-build, php-build,
rust-build, python-build, nodejs-build]
+ needs: [java-build, cpp-build, csharp-build, golang-build, php-build,
python-build, nodejs-build]
if: ${{ always() }}
steps:
- uses: actions/checkout@v2
@@ -159,7 +159,6 @@ jobs:
csharp-${{ needs.csharp-build.result }},\
golang-${{ needs.golang-build.result }},\
php-${{ needs.php-build.result }},\
- rust-${{ needs.rust-build.result }},\
nodejs-${{ needs.nodejs-build.result }},\
python-${{ needs.python-build.result }} | grep -E
'cancelled|failure' -o > null
then
