leizhiyuan commented on PR #1433: URL: https://github.com/apache/rocketmq-clients/pull/1433#issuecomment-6377173339
Rebased onto `master` (`e0cd6e05`, after #1404 / #1381). Two adjustments, both planned in #1412 (¶): - `check_started` now sits at the top of #1381's `receive_internal`, so it also covers `LiteSimpleConsumer::receive`. Note that `LiteSimpleConsumer` already checks the state in its own `receive` / `ack` / `change_invisible_duration`. - The new `client_start_failure_leaves_client_not_started` test uses #1404's 4-argument `Session::new` mock and expects `set_stream_closed_tx`. `aafacfcb` → `50f573af`. `cargo test -- --test-threads=1`: 135 passed (lib), stable over repeated runs; integration and doc tests pass; `fmt --check`, `doc` and `build --examples --all-features` are clean; `clippy -D warnings` is clean. `clippy --all-targets` shows the same 2 extra `await_holding_lock` warnings as before, both from the `MTX` guard in the new tests (see the description). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
