Repository: incubator-rocketmq Updated Branches: refs/heads/ROCKETMQ-57 0de84e20f -> 63de56c7b
[ROCKETMQ-37] Polish log output information in MQClientManager, closes apache/incubator-rocketmq#33, closes apache/incubator-rocketmq#26 Project: http://git-wip-us.apache.org/repos/asf/incubator-rocketmq/repo Commit: http://git-wip-us.apache.org/repos/asf/incubator-rocketmq/commit/69361f60 Tree: http://git-wip-us.apache.org/repos/asf/incubator-rocketmq/tree/69361f60 Diff: http://git-wip-us.apache.org/repos/asf/incubator-rocketmq/diff/69361f60 Branch: refs/heads/ROCKETMQ-57 Commit: 69361f60b70436996e3479e2ed4473f4f1ca2af1 Parents: 4291348 Author: a2888409 <[email protected]> Authored: Fri Jan 20 10:55:48 2017 +0800 Committer: yukon <[email protected]> Committed: Fri Jan 20 10:55:48 2017 +0800 ---------------------------------------------------------------------- .../rocketmq/broker/subscription/SubscriptionGroupManager.java | 2 +- .../java/org/apache/rocketmq/client/impl/MQClientManager.java | 3 ++- 2 files changed, 3 insertions(+), 2 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/incubator-rocketmq/blob/69361f60/broker/src/main/java/org/apache/rocketmq/broker/subscription/SubscriptionGroupManager.java ---------------------------------------------------------------------- diff --git a/broker/src/main/java/org/apache/rocketmq/broker/subscription/SubscriptionGroupManager.java b/broker/src/main/java/org/apache/rocketmq/broker/subscription/SubscriptionGroupManager.java index 92dc5e7..bdf2a01 100644 --- a/broker/src/main/java/org/apache/rocketmq/broker/subscription/SubscriptionGroupManager.java +++ b/broker/src/main/java/org/apache/rocketmq/broker/subscription/SubscriptionGroupManager.java @@ -184,7 +184,7 @@ public class SubscriptionGroupManager extends ConfigManager { this.dataVersion.nextVersion(); this.persist(); } else { - log.warn("delete subscription group failed, subscription group: {} not exist", old); + log.warn("delete subscription group failed, subscription groupName: {} not exist", groupName); } } } http://git-wip-us.apache.org/repos/asf/incubator-rocketmq/blob/69361f60/client/src/main/java/org/apache/rocketmq/client/impl/MQClientManager.java ---------------------------------------------------------------------- diff --git a/client/src/main/java/org/apache/rocketmq/client/impl/MQClientManager.java b/client/src/main/java/org/apache/rocketmq/client/impl/MQClientManager.java index 6f2c9a3..f596b83 100644 --- a/client/src/main/java/org/apache/rocketmq/client/impl/MQClientManager.java +++ b/client/src/main/java/org/apache/rocketmq/client/impl/MQClientManager.java @@ -53,8 +53,9 @@ public class MQClientManager { MQClientInstance prev = this.factoryTable.putIfAbsent(clientId, instance); if (prev != null) { instance = prev; + log.warn("Returned Previous MQClientInstance for clientId:[{}]", clientId); } else { - log.warn("Previous MQClientInstance has created for clientId:[{}]", clientId); + log.info("Created new MQClientInstance for clientId:[{}]", clientId); } }
