Repository: incubator-rocketmq-site Updated Branches: refs/heads/master b8a6095bd -> f8d8f4f93
Added having unit tests as a necessary condition for PR (when applicable). Project: http://git-wip-us.apache.org/repos/asf/incubator-rocketmq-site/repo Commit: http://git-wip-us.apache.org/repos/asf/incubator-rocketmq-site/commit/f8d8f4f9 Tree: http://git-wip-us.apache.org/repos/asf/incubator-rocketmq-site/tree/f8d8f4f9 Diff: http://git-wip-us.apache.org/repos/asf/incubator-rocketmq-site/diff/f8d8f4f9 Branch: refs/heads/master Commit: f8d8f4f93158ffd01ce1cee61ec57e6bb659d3b8 Parents: b8a6095 Author: shtykh_roman <[email protected]> Authored: Thu Mar 16 18:25:53 2017 -0700 Committer: shtykh_roman <[email protected]> Committed: Thu Mar 16 18:25:53 2017 -0700 ---------------------------------------------------------------------- _docs/06-best-practice-pull-request.md | 1 + 1 file changed, 1 insertion(+) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/incubator-rocketmq-site/blob/f8d8f4f9/_docs/06-best-practice-pull-request.md ---------------------------------------------------------------------- diff --git a/_docs/06-best-practice-pull-request.md b/_docs/06-best-practice-pull-request.md index 8331405..7442604 100644 --- a/_docs/06-best-practice-pull-request.md +++ b/_docs/06-best-practice-pull-request.md @@ -76,6 +76,7 @@ Push your branch to Github: Before you create a pull request, make sure 1. A corresponding [JIRA](https://issues.apache.org/jira/browse/ROCKETMQ/) issue is created and has a clear problem description. 2. You follow [Coding Guidelines](/docs/code-guidelines/). +3. You have unit tests for it, whenever applicable. For information on creating pull requests, see [GitHub PR docs](https://help.github.com/articles/creating-a-pull-request/).
