Added having unit tests as a necessary condition for PR (when applicable).
Project: http://git-wip-us.apache.org/repos/asf/incubator-rocketmq-site/repo Commit: http://git-wip-us.apache.org/repos/asf/incubator-rocketmq-site/commit/66ca1735 Tree: http://git-wip-us.apache.org/repos/asf/incubator-rocketmq-site/tree/66ca1735 Diff: http://git-wip-us.apache.org/repos/asf/incubator-rocketmq-site/diff/66ca1735 Branch: refs/heads/asf-site Commit: 66ca1735284b00480aa891a13c8b2f3e3ae21899 Parents: 44d65bc Author: shtykh_roman <[email protected]> Authored: Thu Mar 16 18:25:53 2017 -0700 Committer: yukon <[email protected]> Committed: Fri Mar 17 18:12:51 2017 +0800 ---------------------------------------------------------------------- _docs/06-best-practice-pull-request.md | 1 + 1 file changed, 1 insertion(+) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/incubator-rocketmq-site/blob/66ca1735/_docs/06-best-practice-pull-request.md ---------------------------------------------------------------------- diff --git a/_docs/06-best-practice-pull-request.md b/_docs/06-best-practice-pull-request.md index 8331405..7442604 100644 --- a/_docs/06-best-practice-pull-request.md +++ b/_docs/06-best-practice-pull-request.md @@ -76,6 +76,7 @@ Push your branch to Github: Before you create a pull request, make sure 1. A corresponding [JIRA](https://issues.apache.org/jira/browse/ROCKETMQ/) issue is created and has a clear problem description. 2. You follow [Coding Guidelines](/docs/code-guidelines/). +3. You have unit tests for it, whenever applicable. For information on creating pull requests, see [GitHub PR docs](https://help.github.com/articles/creating-a-pull-request/).
