[
http://opensource.atlassian.com/projects/roller/browse/ROL-1429?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Denis Balazuc updated ROL-1429:
-------------------------------
Attachment: UserData-constructor-enabled-patch-3.1.txt
Replaces
"this.enabled = enabled"
by
"this.enabled = isEnabled"
in the constructor of UserData.java
isEnabled is the parameter passed to the constructor and was ignored, causing
"this.enabled" to always be set to TRUE when using this constructor.
> Enabled flag passed in the UserData constructor is ignored
> ----------------------------------------------------------
>
> Key: ROL-1429
> URL:
> http://opensource.atlassian.com/projects/roller/browse/ROL-1429
> Project: Roller
> Issue Type: Bug
> Reporter: Denis Balazuc
> Assignee: Roller Unassigned
> Priority: Minor
> Attachments: UserData-constructor-enabled-patch-3.1.txt
>
>
> org.apache.roller.pojos.UserData contains a minor typo in its constructor
> which causes the Boolean isEnabled parameter to be ignored.
> The member variable "enabled" is affected to itself, which defaults to TRUE.
> public UserData( String id, String userName,
> String password, String fullName,
> String emailAddress,
> String locale, String timeZone,
> Date dateCreated,
> Boolean isEnabled) {
> [SNIP]
> this.enabled = enabled;
> }
> It is suspected that this is a bug, although, analyzing the usage of this
> constructor shows that only UserData.SYSTEM_USER and UserData.ANONYMOUS_USER
> seem to be using it, so it seems that this bug has no functional impact.
> A small patch is attached to solve this error.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/roller/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
