[
http://opensource.atlassian.com/projects/roller/browse/ROL-1386?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_13764
]
Matthew Montgomery commented on ROL-1386:
-----------------------------------------
The first issue I could not reproduce. Both bupabupa and popyy are flagged as
spam. The second issue I have proposed a patch to the current functionality.
Currently Roller uses a simple "indexOf" test to see if a blacklisted term is
contained in the submitted comment. Due to this, the term "mechanism" is
flagged as spam because "echan" is listed in the server-wide blacklist for
blogs.sun.com. I have provided a patch that changes the behavior of the
"testStringRules" method. Basically, all string rules are treated as a boundary
match, case insensitive regular expression. If what is added as a string rule
produces a PatternMatchException, the submitted content is tested using the
contains method.
This this allows for the following based on the original test case.
Rule: echan
echan (FAILS)
www.echan.com (FAILS)
mechanism (PASSES)
One drawback with this approach is that echanehacn will pass through.
If we assume most admins won't want to mess with crafting regex rules, this new
behavior might be what is more expected. Catching unintentional sub-string
matches is certainly a problem with plain string rules.
--
Matthew
> Keywords on blacklist still let through in comments while non blacklisted
> terms are trapped
> -------------------------------------------------------------------------------------------
>
> Key: ROL-1386
> URL:
> http://opensource.atlassian.com/projects/roller/browse/ROL-1386
> Project: Roller
> Issue Type: Bug
> Reporter: linda skrocki
> Assignee: Roller Unassigned
> Fix For: 4.0
>
>
> BSC examples: bupabupa and popyy
> Additionally, terms that don't appear to be blacklisted are "...marked as
> spam...". Examples: "jacob" and "mechanism"
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/roller/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
