[ 
http://opensource.atlassian.com/projects/roller/browse/ROL-1515?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_13980
 ] 

David Johnson commented on ROL-1515:
------------------------------------

Looks like a good valid patch and uses the calendar in all the right places, 
but I'd to know exactly what problem it solves. I'd like to see the problem, 
apply the patch and then see that the problem is fixed. 

What are the steps to reproduce the problem that this patch fixes?




> WeblogCalendarModel should use timezone setting of weblog consistently
> ----------------------------------------------------------------------
>
>                 Key: ROL-1515
>                 URL: 
> http://opensource.atlassian.com/projects/roller/browse/ROL-1515
>             Project: Roller
>          Issue Type: Bug
>          Components: Page Rendering & Management
>    Affects Versions: 4.0
>         Environment: An site with weblogs'  timezone differ from system 
> default timezone.
>            Reporter: Miles Huang
>            Assignee: David Johnson
>             Fix For: 4.0
>
>         Attachments: WeblogCalendarModel.patch
>
>
> The calendar model converts time between String and Date format with 
> inconsistent time zone. Although a calendar member has been set with weblog's 
> time zone configuration, system default time zone is still be used somewhere 
> implicitly.
> A patch file has been attached here. But it is more like an issue indicator 
> than a final solution. Specifically, the two methods added would be better 
> applied in DateUtil (which is not part of the weblogger app now), in a 
> different manner.
> The DateUtil may add a series of methods as getXXXDateFormat(Calendar cal), 
> with Calendar as input parameter, generate time zone and locale aware 
> DateFormat instances. Then all references to the getXXXDateFormat() methods 
> shall be revised.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: 
http://opensource.atlassian.com/projects/roller/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to