[
https://issues.apache.org/roller/browse/ROL-1733?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14397#action_14397
]
David Johnson commented on ROL-1733:
------------------------------------
Here are some initial comments on this patch and the GSoC submission in general:
- Patch does not include the new Spring XSDs required to run code
(I had to download them myself and add them to the build)
- Patch does not include jars required to run code
(I downloaded them myself from various locations and I'm not certain they are
the correct ones)
- Project proposal was never updated to match what is implemented in the patch
(it still references the OpenID specific methods that no longer exist)
- No documentation has been provided, though documentation was specified in the
plan
- Even after adding the required XSD and jars, patch does not work. When I
attempt to login via OpenID, I am never directory to my OpenID provider's login
page and when the Roller login page appears I get a "Wrong username and
password combination" error and my OpenID URL appears in the Username field
instead of the OpenID URL field. Also, this error appears in the logs:
ERROR 2008-08-19 11:25:56,973
OpenIDAuthenticationProcessingFilter:determineFailureUrl -
Unable to consume claimedIdentity [http://rollerweblogger.org/roller]
org.springframework.security.ui.openid.OpenIDConsumerException: Error
processing ConumerManager authentication
at
org.springframework.security.ui.openid.consumers.OpenID4JavaConsumer.beginConsumption(OpenID4JavaConsumer.java:115)
at
org.springframework.security.ui.openid.OpenIDAuthenticationProcessingFilter.determineFailureUrl(OpenIDAuthenticationProcessingFilter.java:111)
at
org.springframework.security.ui.openid.OpenIDAuthenticationProcessingFilter.unsuccessfulAuthentication(OpenIDAuthenticationProcessingFilter.java:189)
at
org.springframework.security.ui.AbstractProcessingFilter.doFilterHttp(AbstractProcessingFilter.java:253)
at
org.springframework.security.ui.SpringSecurityFilter.doFilter(SpringSecurityFilter.java:53)
...
Caused by: org.openid4java.message.MessageException: 769:
Realm verification failed for:
http://macsnoopdave:8080/roller/roller_j_openid_security_check
at org.openid4java.message.AuthRequest.validate(AuthRequest.java:358)
at
org.openid4java.message.AuthRequest.createAuthRequest(AuthRequest.java:101)
at
org.openid4java.consumer.ConsumerManager.authenticate(ConsumerManager.java:1000)
at
org.openid4java.consumer.ConsumerManager.authenticate(ConsumerManager.java:937)
at
org.springframework.security.ui.openid.consumers.OpenID4JavaConsumer.beginConsumption(OpenID4JavaConsumer.java:112)
... 35 more
(I was able to login with an earlier version of the patch, so this appears to
be a regression)
> Implement OpenID for Roller
> ---------------------------
>
> Key: ROL-1733
> URL: https://issues.apache.org/roller/browse/ROL-1733
> Project: Roller
> Issue Type: New Feature
> Components: User Management
> Reporter: David Johnson
> Assignee: Roller Unassigned
> Attachments: ROL-1733.patch, ROL-1733_v2.patch, ROL-1733_v3.patch,
> spring-security-openid-2.0.2-regext.jar,
> spring-security-openid-2.0.2-regext.jar
>
>
> Represents this proposal:
> http://cwiki.apache.org/confluence/display/ROLLER/Proposal+OpenID+Support
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
