[
https://issues.apache.org/roller/browse/ROL-1776?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Johnson resolved ROL-1776.
--------------------------------
Resolution: Fixed
Fix Version/s: 4.0.1
4.1
Assignee: David Johnson (was: Roller Unassigned)
Thanks for the fix Greg!
Committed here:
http://svn.apache.org/viewvc?rev=735813&view=rev
> feed servlet may not call correct template
> ------------------------------------------
>
> Key: ROL-1776
> URL: https://issues.apache.org/roller/browse/ROL-1776
> Project: Roller
> Issue Type: Bug
> Components: Newsfeed Syndication
> Affects Versions: 4.1
> Environment: Fedora 8
> Reporter: Greg Huber
> Assignee: David Johnson
> Priority: Minor
> Fix For: 4.1, 4.0.1
>
>
> In the feed servlet the "templates/feeds/weblog-search-atom.vm" may not be
> called correclty.
> for the code:
> // determine what template to render with
> boolean siteWide =
> WebloggerRuntimeConfig.isSiteWideWeblog(weblog.getHandle());
> if ("entries".equals(feedRequest.getType()) &&
> feedRequest.getTerm() != null) {
> pageId = "templates/feeds/site-search-atom.vm";
>
> } else if (siteWide && "entries".equals(feedRequest.getType()) &&
> feedRequest.getTerm() != null) {
> pageId = "templates/feeds/weblog-search-atom.vm";
>
>
> } else if (siteWide) {
> pageId =
> "templates/feeds/site-"+feedRequest.getType()+"-"+feedRequest.getFormat()+".vm";
>
> } else {
> pageId =
> "templates/feeds/weblog-"+feedRequest.getType()+"-"+feedRequest.getFormat()+".vm";
> }
> the siteWide refers to "templates/feeds/weblog-search-atom.vm" where it
> should refer to "templates/feeds/site-search-atom.vm".
> ie code may need to be:
> // determine what template to render with
> boolean siteWide =
> WebloggerRuntimeConfig.isSiteWideWeblog(weblog.getHandle());
> if (siteWide && "entries".equals(feedRequest.getType()) &&
> feedRequest.getTerm() != null) {
> pageId = "templates/feeds/site-search-atom.vm";
>
> } else if ("entries".equals(feedRequest.getType()) &&
> feedRequest.getTerm() != null) {
> pageId = "templates/feeds/weblog-search-atom.vm";
>
>
> } else if (siteWide) {
> pageId =
> "templates/feeds/site-"+feedRequest.getType()+"-"+feedRequest.getFormat()+".vm";
>
> } else {
> pageId =
> "templates/feeds/weblog-"+feedRequest.getType()+"-"+feedRequest.getFormat()+".vm";
> }
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
