[
https://issues.apache.org/jira/browse/ROL-685?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Glen Mazza closed ROL-685.
--------------------------
Resolution: Unresolved
Sorry we couldn't get to this. Roller 1.1 too old; please try with later
version of Roller 5.0.x to see which architectural problems remain.
> Improve theme and template management
> -------------------------------------
>
> Key: ROL-685
> URL: https://issues.apache.org/jira/browse/ROL-685
> Project: Roller
> Issue Type: Improvement
> Affects Versions: 1.1
> Reporter: Anil Gangolli
> Assignee: Roller Unassigned
> Priority: Minor
>
> See ROL-665, ROL-664, ROL-680.
> Switching themes leaves cruft. The dev team decided over e-mail as a
> short-term fix to use a no-op _decorator.vm which fixes the immediate symptom
> of those bugs, but the larger issues around proper theme/template remain.
> The main problem is that new theme templates are copied into the users page
> template set. Roller will overwrite existing pages, but there is no cleanup
> of old material because there is basically no way to distinguish what is
> theme material from user-specific pages.
>
> Material from the old theme can break the new one.
>
> If you have the 'basic' theme set, and you switch to "brushedmetal" or
> "movablemanila", you get left with a _decorator.vm that interferes with the
> newly selected theme. You have to go into Page Templates and remove it. If
> you happen to leave it, and then switch to x2, sotto, or sunsets, those too
> are affected. Both of the bugs above seem to be due to this.
> Should we adopt some kind of naming convention that indicates a template is a
> theme element and remove them when switching? (This would be require a
> longer-term change, like 1.2. or later.)
> Other suggestions?
> What about files like comments.vm that are overridden by some themes and also
> get left around?
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
