Author: gmazza
Date: Wed Apr 9 00:46:45 2014
New Revision: 1585868
URL: http://svn.apache.org/r1585868
Log:
More Sonar complaints fixed.
Modified:
roller/trunk/app/src/main/java/org/apache/roller/planet/tasks/GeneratePlanetTask.java
roller/trunk/app/src/main/java/org/apache/roller/planet/tasks/StaticPlanetModel.java
roller/trunk/app/src/main/java/org/apache/roller/util/UUIDGenerator.java
roller/trunk/app/src/main/java/org/apache/roller/weblogger/business/HitCountQueue.java
roller/trunk/app/src/main/java/org/apache/roller/weblogger/business/jpa/JPAWebloggerImpl.java
roller/trunk/app/src/main/java/org/apache/roller/weblogger/business/pings/PingQueueProcessor.java
roller/trunk/app/src/main/java/org/apache/roller/weblogger/business/search/IndexUtil.java
roller/trunk/app/src/main/java/org/apache/roller/weblogger/config/PingConfig.java
roller/trunk/app/src/main/java/org/apache/roller/weblogger/config/WebloggerConfig.java
roller/trunk/app/src/main/java/org/apache/roller/weblogger/pojos/ObjectPermission.java
roller/trunk/app/src/main/java/org/apache/roller/weblogger/pojos/StatCountCountComparator.java
roller/trunk/app/src/main/java/org/apache/roller/weblogger/pojos/WeblogBookmarkFolder.java
roller/trunk/app/src/main/java/org/apache/roller/weblogger/pojos/WeblogCategory.java
roller/trunk/app/src/main/java/org/apache/roller/weblogger/pojos/wrapper/WeblogEntryWrapper.java
roller/trunk/app/src/main/java/org/apache/roller/weblogger/pojos/wrapper/WeblogReferrerWrapper.java
roller/trunk/app/src/main/java/org/apache/roller/weblogger/ui/core/CmaRollerContext.java
roller/trunk/app/src/main/java/org/apache/roller/weblogger/ui/core/filters/CustomOpenIDAuthenticationProcessingFilter.java
roller/trunk/app/src/main/java/org/apache/roller/weblogger/ui/core/filters/LoadSaltFilter.java
roller/trunk/app/src/main/java/org/apache/roller/weblogger/ui/core/plugins/UIPluginManagerImpl.java
roller/trunk/app/src/main/java/org/apache/roller/weblogger/ui/core/util/menu/MenuHelper.java
roller/trunk/app/src/main/java/org/apache/roller/weblogger/ui/rendering/RendererManager.java
roller/trunk/app/src/main/java/org/apache/roller/weblogger/ui/rendering/model/ConfigModel.java
roller/trunk/app/src/main/java/org/apache/roller/weblogger/ui/rendering/model/FeedModel.java
roller/trunk/app/src/main/java/org/apache/roller/weblogger/ui/rendering/model/PreviewURLModel.java
roller/trunk/app/src/main/java/org/apache/roller/weblogger/ui/rendering/model/SearchResultsFeedModel.java
roller/trunk/app/src/main/java/org/apache/roller/weblogger/ui/rendering/pagers/UsersPager.java
roller/trunk/app/src/main/java/org/apache/roller/weblogger/ui/rendering/pagers/WeblogsPager.java
roller/trunk/app/src/main/java/org/apache/roller/weblogger/ui/rendering/util/ModDateHeaderUtil.java
roller/trunk/app/src/main/java/org/apache/roller/weblogger/ui/rendering/util/cache/SaltCache.java
roller/trunk/app/src/main/java/org/apache/roller/weblogger/ui/struts2/admin/CacheInfo.java
roller/trunk/app/src/main/java/org/apache/roller/weblogger/ui/struts2/editor/WeblogConfigBean.java
roller/trunk/app/src/main/java/org/apache/roller/weblogger/ui/struts2/util/UIAction.java
roller/trunk/app/src/main/java/org/apache/roller/weblogger/util/Blacklist.java
roller/trunk/app/src/main/java/org/apache/roller/weblogger/util/BlacklistChecker.java
roller/trunk/app/src/main/java/org/apache/roller/weblogger/util/I18nMessages.java
roller/trunk/app/src/main/java/org/apache/roller/weblogger/util/IPBanList.java
roller/trunk/app/src/main/java/org/apache/roller/weblogger/util/cache/LRUCacheImpl.java
roller/trunk/app/src/main/java/org/apache/roller/weblogger/webservices/xmlrpc/BloggerAPIHandler.java
Modified:
roller/trunk/app/src/main/java/org/apache/roller/planet/tasks/GeneratePlanetTask.java
URL:
http://svn.apache.org/viewvc/roller/trunk/app/src/main/java/org/apache/roller/planet/tasks/GeneratePlanetTask.java?rev=1585868&r1=1585867&r2=1585868&view=diff
==============================================================================
---
roller/trunk/app/src/main/java/org/apache/roller/planet/tasks/GeneratePlanetTask.java
(original)
+++
roller/trunk/app/src/main/java/org/apache/roller/planet/tasks/GeneratePlanetTask.java
Wed Apr 9 00:46:45 2014
@@ -22,8 +22,6 @@ import java.io.File;
import java.util.Date;
import org.apache.commons.logging.Log;
import org.apache.commons.logging.LogFactory;
-import org.apache.roller.weblogger.business.Weblogger;
-import org.apache.roller.weblogger.business.WebloggerFactory;
import org.apache.roller.weblogger.config.WebloggerConfig;
import org.apache.roller.weblogger.util.Utilities;
//import org.apache.roller.util.UtilitiesModel;
Modified:
roller/trunk/app/src/main/java/org/apache/roller/planet/tasks/StaticPlanetModel.java
URL:
http://svn.apache.org/viewvc/roller/trunk/app/src/main/java/org/apache/roller/planet/tasks/StaticPlanetModel.java?rev=1585868&r1=1585867&r2=1585868&view=diff
==============================================================================
---
roller/trunk/app/src/main/java/org/apache/roller/planet/tasks/StaticPlanetModel.java
(original)
+++
roller/trunk/app/src/main/java/org/apache/roller/planet/tasks/StaticPlanetModel.java
Wed Apr 9 00:46:45 2014
@@ -19,8 +19,6 @@ package org.apache.roller.planet.tasks;
import java.util.Collections;
import java.util.List;
-import org.apache.commons.logging.Log;
-import org.apache.commons.logging.LogFactory;
import org.apache.roller.RollerException;
import org.apache.roller.planet.business.PlanetManager;
import org.apache.roller.planet.pojos.PlanetGroup;
@@ -34,7 +32,6 @@ import org.apache.roller.weblogger.busin
* to be duck-type compatible with old PlanetTool templates.
*/
public class StaticPlanetModel {
- private static Log logger =
LogFactory.getFactory().getInstance(StaticPlanetModel.class);
PlanetManager planetManager = null;
Modified:
roller/trunk/app/src/main/java/org/apache/roller/util/UUIDGenerator.java
URL:
http://svn.apache.org/viewvc/roller/trunk/app/src/main/java/org/apache/roller/util/UUIDGenerator.java?rev=1585868&r1=1585867&r2=1585868&view=diff
==============================================================================
--- roller/trunk/app/src/main/java/org/apache/roller/util/UUIDGenerator.java
(original)
+++ roller/trunk/app/src/main/java/org/apache/roller/util/UUIDGenerator.java
Wed Apr 9 00:46:45 2014
@@ -24,7 +24,7 @@ import java.util.UUID;
/**
* Generates UUID values.
*/
-public class UUIDGenerator {
+public final class UUIDGenerator {
// non-instantiable
private UUIDGenerator() {}
Modified:
roller/trunk/app/src/main/java/org/apache/roller/weblogger/business/HitCountQueue.java
URL:
http://svn.apache.org/viewvc/roller/trunk/app/src/main/java/org/apache/roller/weblogger/business/HitCountQueue.java?rev=1585868&r1=1585867&r2=1585868&view=diff
==============================================================================
---
roller/trunk/app/src/main/java/org/apache/roller/weblogger/business/HitCountQueue.java
(original)
+++
roller/trunk/app/src/main/java/org/apache/roller/weblogger/business/HitCountQueue.java
Wed Apr 9 00:46:45 2014
@@ -41,7 +41,7 @@ import org.apache.roller.weblogger.pojos
* TODO: we may want to make this an interface that is pluggable if there is
* some indication that users want to override this implementation.
*/
-public class HitCountQueue {
+public final class HitCountQueue {
private static Log log = LogFactory.getLog(HitCountQueue.class);
Modified:
roller/trunk/app/src/main/java/org/apache/roller/weblogger/business/jpa/JPAWebloggerImpl.java
URL:
http://svn.apache.org/viewvc/roller/trunk/app/src/main/java/org/apache/roller/weblogger/business/jpa/JPAWebloggerImpl.java?rev=1585868&r1=1585867&r2=1585868&view=diff
==============================================================================
---
roller/trunk/app/src/main/java/org/apache/roller/weblogger/business/jpa/JPAWebloggerImpl.java
(original)
+++
roller/trunk/app/src/main/java/org/apache/roller/weblogger/business/jpa/JPAWebloggerImpl.java
Wed Apr 9 00:46:45 2014
@@ -17,8 +17,6 @@
*/
package org.apache.roller.weblogger.business.jpa;
-import org.apache.commons.logging.Log;
-import org.apache.commons.logging.LogFactory;
import org.apache.roller.planet.business.PlanetManager;
import org.apache.roller.planet.business.PlanetURLStrategy;
import org.apache.roller.planet.business.fetcher.FeedFetcher;
@@ -51,8 +49,6 @@ public class JPAWebloggerImpl extends We
static final long serialVersionUID = 5256135928578074652L;
- private static Log logger = LogFactory.getLog(JPAWebloggerImpl.class);
-
// a persistence utility class
private final JPAPersistenceStrategy strategy;
Modified:
roller/trunk/app/src/main/java/org/apache/roller/weblogger/business/pings/PingQueueProcessor.java
URL:
http://svn.apache.org/viewvc/roller/trunk/app/src/main/java/org/apache/roller/weblogger/business/pings/PingQueueProcessor.java?rev=1585868&r1=1585867&r2=1585868&view=diff
==============================================================================
---
roller/trunk/app/src/main/java/org/apache/roller/weblogger/business/pings/PingQueueProcessor.java
(original)
+++
roller/trunk/app/src/main/java/org/apache/roller/weblogger/business/pings/PingQueueProcessor.java
Wed Apr 9 00:46:45 2014
@@ -35,7 +35,7 @@ import org.apache.roller.weblogger.pojos
*
* @author <a href="mailto:[email protected]";>Anil Gangolli</a>
*/
-public class PingQueueProcessor {
+public final class PingQueueProcessor {
private static final Log LOGGER =
LogFactory.getLog(PingQueueProcessor.class);
Modified:
roller/trunk/app/src/main/java/org/apache/roller/weblogger/business/search/IndexUtil.java
URL:
http://svn.apache.org/viewvc/roller/trunk/app/src/main/java/org/apache/roller/weblogger/business/search/IndexUtil.java?rev=1585868&r1=1585867&r2=1585868&view=diff
==============================================================================
---
roller/trunk/app/src/main/java/org/apache/roller/weblogger/business/search/IndexUtil.java
(original)
+++
roller/trunk/app/src/main/java/org/apache/roller/weblogger/business/search/IndexUtil.java
Wed Apr 9 00:46:45 2014
@@ -31,7 +31,7 @@ import org.apache.lucene.index.Term;
*
* @author Mindaugas Idzelis ([email protected])
*/
-public class IndexUtil {
+public final class IndexUtil {
private IndexUtil() {}
Modified:
roller/trunk/app/src/main/java/org/apache/roller/weblogger/config/PingConfig.java
URL:
http://svn.apache.org/viewvc/roller/trunk/app/src/main/java/org/apache/roller/weblogger/config/PingConfig.java?rev=1585868&r1=1585867&r2=1585868&view=diff
==============================================================================
---
roller/trunk/app/src/main/java/org/apache/roller/weblogger/config/PingConfig.java
(original)
+++
roller/trunk/app/src/main/java/org/apache/roller/weblogger/config/PingConfig.java
Wed Apr 9 00:46:45 2014
@@ -40,7 +40,7 @@ import java.util.regex.Pattern;
*
* @author <a href="mailto:[email protected]";>Anil Gangolli</a>
*/
-public class PingConfig {
+public final class PingConfig {
private static final Log LOGGER = LogFactory.getLog(PingConfig.class);
Modified:
roller/trunk/app/src/main/java/org/apache/roller/weblogger/config/WebloggerConfig.java
URL:
http://svn.apache.org/viewvc/roller/trunk/app/src/main/java/org/apache/roller/weblogger/config/WebloggerConfig.java?rev=1585868&r1=1585867&r2=1585868&view=diff
==============================================================================
---
roller/trunk/app/src/main/java/org/apache/roller/weblogger/config/WebloggerConfig.java
(original)
+++
roller/trunk/app/src/main/java/org/apache/roller/weblogger/config/WebloggerConfig.java
Wed Apr 9 00:46:45 2014
@@ -32,7 +32,7 @@ import org.apache.roller.util.PropertyEx
/**
* This is the single entry point for accessing configuration properties in
Roller.
*/
-public class WebloggerConfig {
+public final class WebloggerConfig {
private static String default_config =
"/org/apache/roller/weblogger/config/roller.properties";
private static String custom_config = "/roller-custom.properties";
Modified:
roller/trunk/app/src/main/java/org/apache/roller/weblogger/pojos/ObjectPermission.java
URL:
http://svn.apache.org/viewvc/roller/trunk/app/src/main/java/org/apache/roller/weblogger/pojos/ObjectPermission.java?rev=1585868&r1=1585867&r2=1585868&view=diff
==============================================================================
---
roller/trunk/app/src/main/java/org/apache/roller/weblogger/pojos/ObjectPermission.java
(original)
+++
roller/trunk/app/src/main/java/org/apache/roller/weblogger/pojos/ObjectPermission.java
Wed Apr 9 00:46:45 2014
@@ -19,8 +19,6 @@
package org.apache.roller.weblogger.pojos;
import java.util.Date;
-import org.apache.commons.logging.Log;
-import org.apache.commons.logging.LogFactory;
import org.apache.roller.util.UUIDGenerator;
@@ -28,8 +26,6 @@ import org.apache.roller.util.UUIDGenera
* Base permission class for Roller.
*/
public abstract class ObjectPermission extends RollerPermission {
- private static Log log = LogFactory.getLog(ObjectPermission.class);
-
protected String id = UUIDGenerator.generateUUID();
protected String userName;
protected String objectType;
Modified:
roller/trunk/app/src/main/java/org/apache/roller/weblogger/pojos/StatCountCountComparator.java
URL:
http://svn.apache.org/viewvc/roller/trunk/app/src/main/java/org/apache/roller/weblogger/pojos/StatCountCountComparator.java?rev=1585868&r1=1585867&r2=1585868&view=diff
==============================================================================
---
roller/trunk/app/src/main/java/org/apache/roller/weblogger/pojos/StatCountCountComparator.java
(original)
+++
roller/trunk/app/src/main/java/org/apache/roller/weblogger/pojos/StatCountCountComparator.java
Wed Apr 9 00:46:45 2014
@@ -24,18 +24,13 @@ import java.io.Serializable;
/**
* @author Markus Fuchs
*/
-public class StatCountCountComparator implements Comparator, Serializable {
+public final class StatCountCountComparator implements Comparator,
Serializable {
private static final long serialVersionUID = 4811314286365625712L;
private static StatCountCountComparator instance = new
StatCountCountComparator();
- /**
- *
- */
- private StatCountCountComparator() {
-
- }
+ private StatCountCountComparator() {}
/**
* Compares two <em>StatCount</em> instances according to their count
values.
Modified:
roller/trunk/app/src/main/java/org/apache/roller/weblogger/pojos/WeblogBookmarkFolder.java
URL:
http://svn.apache.org/viewvc/roller/trunk/app/src/main/java/org/apache/roller/weblogger/pojos/WeblogBookmarkFolder.java?rev=1585868&r1=1585867&r2=1585868&view=diff
==============================================================================
---
roller/trunk/app/src/main/java/org/apache/roller/weblogger/pojos/WeblogBookmarkFolder.java
(original)
+++
roller/trunk/app/src/main/java/org/apache/roller/weblogger/pojos/WeblogBookmarkFolder.java
Wed Apr 9 00:46:45 2014
@@ -23,8 +23,6 @@ import java.util.ArrayList;
import java.util.List;
import org.apache.commons.lang3.builder.EqualsBuilder;
import org.apache.commons.lang3.builder.HashCodeBuilder;
-import org.apache.commons.logging.Log;
-import org.apache.commons.logging.LogFactory;
import org.apache.roller.weblogger.WebloggerException;
import org.apache.roller.weblogger.business.BookmarkManager;
@@ -39,8 +37,6 @@ import org.apache.roller.util.UUIDGenera
public class WeblogBookmarkFolder implements Serializable,
Comparable<WeblogBookmarkFolder> {
public static final long serialVersionUID = -6272468884763861944L;
-
- private static Log log = LogFactory.getLog(WeblogBookmarkFolder.class);
// attributes
private String id = UUIDGenerator.generateUUID();
Modified:
roller/trunk/app/src/main/java/org/apache/roller/weblogger/pojos/WeblogCategory.java
URL:
http://svn.apache.org/viewvc/roller/trunk/app/src/main/java/org/apache/roller/weblogger/pojos/WeblogCategory.java?rev=1585868&r1=1585867&r2=1585868&view=diff
==============================================================================
---
roller/trunk/app/src/main/java/org/apache/roller/weblogger/pojos/WeblogCategory.java
(original)
+++
roller/trunk/app/src/main/java/org/apache/roller/weblogger/pojos/WeblogCategory.java
Wed Apr 9 00:46:45 2014
@@ -22,8 +22,6 @@ import java.io.Serializable;
import java.util.List;
import org.apache.commons.lang3.builder.EqualsBuilder;
import org.apache.commons.lang3.builder.HashCodeBuilder;
-import org.apache.commons.logging.Log;
-import org.apache.commons.logging.LogFactory;
import org.apache.roller.weblogger.WebloggerException;
import org.apache.roller.weblogger.business.WebloggerFactory;
import org.apache.roller.weblogger.business.WeblogEntryManager;
@@ -37,8 +35,6 @@ public class WeblogCategory implements S
public static final long serialVersionUID = 1435782148712018954L;
- private static Log log = LogFactory.getLog(WeblogCategory.class);
-
// attributes
private String id = UUIDGenerator.generateUUID();
private String name = null;
Modified:
roller/trunk/app/src/main/java/org/apache/roller/weblogger/pojos/wrapper/WeblogEntryWrapper.java
URL:
http://svn.apache.org/viewvc/roller/trunk/app/src/main/java/org/apache/roller/weblogger/pojos/wrapper/WeblogEntryWrapper.java?rev=1585868&r1=1585867&r2=1585868&view=diff
==============================================================================
---
roller/trunk/app/src/main/java/org/apache/roller/weblogger/pojos/wrapper/WeblogEntryWrapper.java
(original)
+++
roller/trunk/app/src/main/java/org/apache/roller/weblogger/pojos/wrapper/WeblogEntryWrapper.java
Wed Apr 9 00:46:45 2014
@@ -39,7 +39,7 @@ import org.apache.roller.weblogger.util.
/**
* Pojo safety wrapper for WeblogEntry objects.
*/
-public class WeblogEntryWrapper {
+public final class WeblogEntryWrapper {
// keep a reference to the wrapped pojo
private final WeblogEntry pojo;
Modified:
roller/trunk/app/src/main/java/org/apache/roller/weblogger/pojos/wrapper/WeblogReferrerWrapper.java
URL:
http://svn.apache.org/viewvc/roller/trunk/app/src/main/java/org/apache/roller/weblogger/pojos/wrapper/WeblogReferrerWrapper.java?rev=1585868&r1=1585867&r2=1585868&view=diff
==============================================================================
---
roller/trunk/app/src/main/java/org/apache/roller/weblogger/pojos/wrapper/WeblogReferrerWrapper.java
(original)
+++
roller/trunk/app/src/main/java/org/apache/roller/weblogger/pojos/wrapper/WeblogReferrerWrapper.java
Wed Apr 9 00:46:45 2014
@@ -25,7 +25,7 @@ import org.apache.roller.weblogger.pojos
/**
* Pojo safety wrapper for WeblogReferrer object.
*/
-public class WeblogReferrerWrapper {
+public final class WeblogReferrerWrapper {
// keep a reference to the wrapped pojo
private final WeblogReferrer pojo;
Modified:
roller/trunk/app/src/main/java/org/apache/roller/weblogger/ui/core/CmaRollerContext.java
URL:
http://svn.apache.org/viewvc/roller/trunk/app/src/main/java/org/apache/roller/weblogger/ui/core/CmaRollerContext.java?rev=1585868&r1=1585867&r2=1585868&view=diff
==============================================================================
---
roller/trunk/app/src/main/java/org/apache/roller/weblogger/ui/core/CmaRollerContext.java
(original)
+++
roller/trunk/app/src/main/java/org/apache/roller/weblogger/ui/core/CmaRollerContext.java
Wed Apr 9 00:46:45 2014
@@ -19,8 +19,6 @@
package org.apache.roller.weblogger.ui.core;
import javax.servlet.ServletContext;
-import org.apache.commons.logging.Log;
-import org.apache.commons.logging.LogFactory;
/**
@@ -31,8 +29,6 @@ import org.apache.commons.logging.LogFac
*/
public class CmaRollerContext extends RollerContext {
- private static Log log = LogFactory.getLog(CmaRollerContext.class);
-
public CmaRollerContext() {
super();
}
Modified:
roller/trunk/app/src/main/java/org/apache/roller/weblogger/ui/core/filters/CustomOpenIDAuthenticationProcessingFilter.java
URL:
http://svn.apache.org/viewvc/roller/trunk/app/src/main/java/org/apache/roller/weblogger/ui/core/filters/CustomOpenIDAuthenticationProcessingFilter.java?rev=1585868&r1=1585867&r2=1585868&view=diff
==============================================================================
---
roller/trunk/app/src/main/java/org/apache/roller/weblogger/ui/core/filters/CustomOpenIDAuthenticationProcessingFilter.java
(original)
+++
roller/trunk/app/src/main/java/org/apache/roller/weblogger/ui/core/filters/CustomOpenIDAuthenticationProcessingFilter.java
Wed Apr 9 00:46:45 2014
@@ -32,7 +32,6 @@ import org.springframework.security.core
import org.springframework.security.core.GrantedAuthority;
import org.springframework.security.openid.OpenIDAuthenticationToken;
import org.springframework.security.openid.OpenIDAuthenticationFilter;
-import org.springframework.security.openid.OpenIDConsumer;
//import org.springframework.security.userdetails.openid.OpenIDUserAttribute;
@@ -43,8 +42,6 @@ import org.springframework.security.open
public class CustomOpenIDAuthenticationProcessingFilter
extends OpenIDAuthenticationFilter implements Filter {
- private OpenIDConsumer consumer;
- private String claimedIdentityFieldName = DEFAULT_CLAIMED_IDENTITY_FIELD;
private static Log log =
LogFactory.getLog(CustomOpenIDAuthenticationProcessingFilter.class);
/**
@@ -52,7 +49,7 @@ public class CustomOpenIDAuthenticationP
*/
@Override
public Authentication attemptAuthentication(HttpServletRequest req,
HttpServletResponse rsp) throws IOException {
- OpenIDAuthenticationToken auth = null;
+ OpenIDAuthenticationToken auth;
// Processing standard OpenId user authentication
auth = (OpenIDAuthenticationToken) super.attemptAuthentication(req,
rsp);
Modified:
roller/trunk/app/src/main/java/org/apache/roller/weblogger/ui/core/filters/LoadSaltFilter.java
URL:
http://svn.apache.org/viewvc/roller/trunk/app/src/main/java/org/apache/roller/weblogger/ui/core/filters/LoadSaltFilter.java?rev=1585868&r1=1585867&r2=1585868&view=diff
==============================================================================
---
roller/trunk/app/src/main/java/org/apache/roller/weblogger/ui/core/filters/LoadSaltFilter.java
(original)
+++
roller/trunk/app/src/main/java/org/apache/roller/weblogger/ui/core/filters/LoadSaltFilter.java
Wed Apr 9 00:46:45 2014
@@ -23,8 +23,6 @@ import java.security.SecureRandom;
import javax.servlet.*;
import javax.servlet.http.HttpServletRequest;
import org.apache.commons.lang3.RandomStringUtils;
-import org.apache.commons.logging.Log;
-import org.apache.commons.logging.LogFactory;
import org.apache.roller.weblogger.ui.rendering.util.cache.SaltCache;
/**
Modified:
roller/trunk/app/src/main/java/org/apache/roller/weblogger/ui/core/plugins/UIPluginManagerImpl.java
URL:
http://svn.apache.org/viewvc/roller/trunk/app/src/main/java/org/apache/roller/weblogger/ui/core/plugins/UIPluginManagerImpl.java?rev=1585868&r1=1585867&r2=1585868&view=diff
==============================================================================
---
roller/trunk/app/src/main/java/org/apache/roller/weblogger/ui/core/plugins/UIPluginManagerImpl.java
(original)
+++
roller/trunk/app/src/main/java/org/apache/roller/weblogger/ui/core/plugins/UIPluginManagerImpl.java
Wed Apr 9 00:46:45 2014
@@ -31,7 +31,7 @@ import org.apache.commons.lang3.StringUt
/**
* Plugin management for UI layer plugins.
*/
-public class UIPluginManagerImpl implements UIPluginManager {
+public final class UIPluginManagerImpl implements UIPluginManager {
private static Log log = LogFactory.getLog(UIPluginManagerImpl.class);
Modified:
roller/trunk/app/src/main/java/org/apache/roller/weblogger/ui/core/util/menu/MenuHelper.java
URL:
http://svn.apache.org/viewvc/roller/trunk/app/src/main/java/org/apache/roller/weblogger/ui/core/util/menu/MenuHelper.java?rev=1585868&r1=1585867&r2=1585868&view=diff
==============================================================================
---
roller/trunk/app/src/main/java/org/apache/roller/weblogger/ui/core/util/menu/MenuHelper.java
(original)
+++
roller/trunk/app/src/main/java/org/apache/roller/weblogger/ui/core/util/menu/MenuHelper.java
Wed Apr 9 00:46:45 2014
@@ -48,7 +48,7 @@ import org.jdom.input.SAXBuilder;
* Note : Debug logging disabled here as it is too expensive time wise.
*
*/
-public class MenuHelper {
+public final class MenuHelper {
private static Log log = LogFactory.getLog(MenuHelper.class);
Modified:
roller/trunk/app/src/main/java/org/apache/roller/weblogger/ui/rendering/RendererManager.java
URL:
http://svn.apache.org/viewvc/roller/trunk/app/src/main/java/org/apache/roller/weblogger/ui/rendering/RendererManager.java?rev=1585868&r1=1585867&r2=1585868&view=diff
==============================================================================
---
roller/trunk/app/src/main/java/org/apache/roller/weblogger/ui/rendering/RendererManager.java
(original)
+++
roller/trunk/app/src/main/java/org/apache/roller/weblogger/ui/rendering/RendererManager.java
Wed Apr 9 00:46:45 2014
@@ -34,7 +34,7 @@ import org.apache.roller.weblogger.ui.re
* rendering technology. This allows us to provide easily pluggable rendering
* implementations.
*/
-public class RendererManager {
+public final class RendererManager {
private static Log log = LogFactory.getLog(RendererManager.class);
// a set of all renderer factories we are consulting
Modified:
roller/trunk/app/src/main/java/org/apache/roller/weblogger/ui/rendering/model/ConfigModel.java
URL:
http://svn.apache.org/viewvc/roller/trunk/app/src/main/java/org/apache/roller/weblogger/ui/rendering/model/ConfigModel.java?rev=1585868&r1=1585867&r2=1585868&view=diff
==============================================================================
---
roller/trunk/app/src/main/java/org/apache/roller/weblogger/ui/rendering/model/ConfigModel.java
(original)
+++
roller/trunk/app/src/main/java/org/apache/roller/weblogger/ui/rendering/model/ConfigModel.java
Wed Apr 9 00:46:45 2014
@@ -19,8 +19,6 @@
package org.apache.roller.weblogger.ui.rendering.model;
import java.util.Map;
-import org.apache.commons.logging.Log;
-import org.apache.commons.logging.LogFactory;
import org.apache.roller.weblogger.WebloggerException;
import org.apache.roller.weblogger.business.WebloggerFactory;
import org.apache.roller.weblogger.config.WebloggerRuntimeConfig;
@@ -31,9 +29,6 @@ import org.apache.roller.weblogger.confi
*/
public class ConfigModel implements Model {
- private static Log log = LogFactory.getLog(ConfigModel.class);
-
-
/** Template context name to be used for model */
public String getModelName() {
return "config";
Modified:
roller/trunk/app/src/main/java/org/apache/roller/weblogger/ui/rendering/model/FeedModel.java
URL:
http://svn.apache.org/viewvc/roller/trunk/app/src/main/java/org/apache/roller/weblogger/ui/rendering/model/FeedModel.java?rev=1585868&r1=1585867&r2=1585868&view=diff
==============================================================================
---
roller/trunk/app/src/main/java/org/apache/roller/weblogger/ui/rendering/model/FeedModel.java
(original)
+++
roller/trunk/app/src/main/java/org/apache/roller/weblogger/ui/rendering/model/FeedModel.java
Wed Apr 9 00:46:45 2014
@@ -21,8 +21,6 @@ package org.apache.roller.weblogger.ui.r
import java.util.HashMap;
import java.util.List;
import java.util.Map;
-import org.apache.commons.logging.Log;
-import org.apache.commons.logging.LogFactory;
import org.apache.roller.weblogger.WebloggerException;
import org.apache.roller.weblogger.business.URLStrategy;
import org.apache.roller.weblogger.business.WebloggerFactory;
@@ -43,8 +41,6 @@ import org.apache.roller.weblogger.util.
*/
public class FeedModel implements Model {
- private static Log log = LogFactory.getLog(FeedModel.class);
-
private static int DEFAULT_ENTRIES =
WebloggerRuntimeConfig.getIntProperty("site.newsfeeds.defaultEntries");
private WeblogFeedRequest feedRequest = null;
Modified:
roller/trunk/app/src/main/java/org/apache/roller/weblogger/ui/rendering/model/PreviewURLModel.java
URL:
http://svn.apache.org/viewvc/roller/trunk/app/src/main/java/org/apache/roller/weblogger/ui/rendering/model/PreviewURLModel.java?rev=1585868&r1=1585867&r2=1585868&view=diff
==============================================================================
---
roller/trunk/app/src/main/java/org/apache/roller/weblogger/ui/rendering/model/PreviewURLModel.java
(original)
+++
roller/trunk/app/src/main/java/org/apache/roller/weblogger/ui/rendering/model/PreviewURLModel.java
Wed Apr 9 00:46:45 2014
@@ -32,7 +32,6 @@ import org.apache.roller.weblogger.ui.re
*/
public class PreviewURLModel extends URLModel {
- private WeblogPreviewRequest previewRequest = null;
private Weblog weblog = null;
private URLStrategy urlStrategy = null;
@@ -48,9 +47,7 @@ public class PreviewURLModel extends URL
// PreviewURLModel only works on preview requests, so cast
weblogRequest
// into a WeblogPreviewRequest and if it fails then throw exception
- if(weblogRequest instanceof WeblogPreviewRequest) {
- this.previewRequest = (WeblogPreviewRequest) weblogRequest;
- } else {
+ if(!(weblogRequest instanceof WeblogPreviewRequest)) {
throw new WebloggerException("weblogRequest is not a
WeblogPreviewRequest."+
" PreviewURLModel only supports preview requests.");
}
Modified:
roller/trunk/app/src/main/java/org/apache/roller/weblogger/ui/rendering/model/SearchResultsFeedModel.java
URL:
http://svn.apache.org/viewvc/roller/trunk/app/src/main/java/org/apache/roller/weblogger/ui/rendering/model/SearchResultsFeedModel.java?rev=1585868&r1=1585867&r2=1585868&view=diff
==============================================================================
---
roller/trunk/app/src/main/java/org/apache/roller/weblogger/ui/rendering/model/SearchResultsFeedModel.java
(original)
+++
roller/trunk/app/src/main/java/org/apache/roller/weblogger/ui/rendering/model/SearchResultsFeedModel.java
Wed Apr 9 00:46:45 2014
@@ -29,8 +29,6 @@ import java.util.TreeSet;
import org.apache.commons.lang3.StringEscapeUtils;
import org.apache.commons.lang3.StringUtils;
-import org.apache.commons.logging.Log;
-import org.apache.commons.logging.LogFactory;
import org.apache.lucene.document.Document;
import org.apache.lucene.search.ScoreDoc;
import org.apache.lucene.search.TopFieldDocs;
@@ -62,8 +60,6 @@ import org.apache.roller.weblogger.util.
*/
public class SearchResultsFeedModel implements Model {
- private static Log log =
LogFactory.getLog(SearchResultsFeedModel.class);
-
private WeblogFeedRequest feedRequest = null;
private URLStrategy urlStrategy = null;
private Weblog weblog = null;
Modified:
roller/trunk/app/src/main/java/org/apache/roller/weblogger/ui/rendering/pagers/UsersPager.java
URL:
http://svn.apache.org/viewvc/roller/trunk/app/src/main/java/org/apache/roller/weblogger/ui/rendering/pagers/UsersPager.java?rev=1585868&r1=1585867&r2=1585868&view=diff
==============================================================================
---
roller/trunk/app/src/main/java/org/apache/roller/weblogger/ui/rendering/pagers/UsersPager.java
(original)
+++
roller/trunk/app/src/main/java/org/apache/roller/weblogger/ui/rendering/pagers/UsersPager.java
Wed Apr 9 00:46:45 2014
@@ -40,8 +40,6 @@ public class UsersPager extends Abstract
private static Log log = LogFactory.getLog(UsersPager.class);
private String letter = null;
- private String locale = null;
- private int sinceDays = -1;
private int length = 0;
// collection for the pager
@@ -61,8 +59,6 @@ public class UsersPager extends Abstract
super(strat, baseUrl, page);
- this.locale = locale;
- this.sinceDays = sinceDays;
this.length = length;
// initialize the collection
@@ -82,8 +78,6 @@ public class UsersPager extends Abstract
super(strat, baseUrl, page);
this.letter = letter;
- this.locale = locale;
- this.sinceDays = sinceDays;
this.length = length;
// initialize the collection
Modified:
roller/trunk/app/src/main/java/org/apache/roller/weblogger/ui/rendering/pagers/WeblogsPager.java
URL:
http://svn.apache.org/viewvc/roller/trunk/app/src/main/java/org/apache/roller/weblogger/ui/rendering/pagers/WeblogsPager.java?rev=1585868&r1=1585867&r2=1585868&view=diff
==============================================================================
---
roller/trunk/app/src/main/java/org/apache/roller/weblogger/ui/rendering/pagers/WeblogsPager.java
(original)
+++
roller/trunk/app/src/main/java/org/apache/roller/weblogger/ui/rendering/pagers/WeblogsPager.java
Wed Apr 9 00:46:45 2014
@@ -42,7 +42,6 @@ public class WeblogsPager extends Abstra
private static Log log = LogFactory.getLog(WeblogsPager.class);
private String letter = null;
- private String locale = null;
private int sinceDays = -1;
private int length = 0;
@@ -63,7 +62,6 @@ public class WeblogsPager extends Abstra
super(strat, baseUrl, page);
- this.locale = locale;
this.sinceDays = sinceDays;
this.length = length;
@@ -84,7 +82,6 @@ public class WeblogsPager extends Abstra
super(strat, baseUrl, page);
this.letter = letter;
- this.locale = locale;
this.sinceDays = sinceDays;
this.length = length;
Modified:
roller/trunk/app/src/main/java/org/apache/roller/weblogger/ui/rendering/util/ModDateHeaderUtil.java
URL:
http://svn.apache.org/viewvc/roller/trunk/app/src/main/java/org/apache/roller/weblogger/ui/rendering/util/ModDateHeaderUtil.java?rev=1585868&r1=1585867&r2=1585868&view=diff
==============================================================================
---
roller/trunk/app/src/main/java/org/apache/roller/weblogger/ui/rendering/util/ModDateHeaderUtil.java
(original)
+++
roller/trunk/app/src/main/java/org/apache/roller/weblogger/ui/rendering/util/ModDateHeaderUtil.java
Wed Apr 9 00:46:45 2014
@@ -33,7 +33,7 @@ import org.apache.roller.weblogger.ui.re
/**
* Utility class to localize the modification date header-related logic.
*/
-public class ModDateHeaderUtil {
+public final class ModDateHeaderUtil {
private static Log log = LogFactory.getLog(ModDateHeaderUtil.class);
Modified:
roller/trunk/app/src/main/java/org/apache/roller/weblogger/ui/rendering/util/cache/SaltCache.java
URL:
http://svn.apache.org/viewvc/roller/trunk/app/src/main/java/org/apache/roller/weblogger/ui/rendering/util/cache/SaltCache.java?rev=1585868&r1=1585867&r2=1585868&view=diff
==============================================================================
---
roller/trunk/app/src/main/java/org/apache/roller/weblogger/ui/rendering/util/cache/SaltCache.java
(original)
+++
roller/trunk/app/src/main/java/org/apache/roller/weblogger/ui/rendering/util/cache/SaltCache.java
Wed Apr 9 00:46:45 2014
@@ -35,7 +35,7 @@ import org.apache.roller.weblogger.util.
* by Roller. If you're running distributed, then you must use a distributed
* cache, e.g. memcached
*/
-public class SaltCache {
+public final class SaltCache {
private static Log log = LogFactory.getLog(SaltCache.class);
// a unique identifier for this cache, this is used as the prefix for
Modified:
roller/trunk/app/src/main/java/org/apache/roller/weblogger/ui/struts2/admin/CacheInfo.java
URL:
http://svn.apache.org/viewvc/roller/trunk/app/src/main/java/org/apache/roller/weblogger/ui/struts2/admin/CacheInfo.java?rev=1585868&r1=1585867&r2=1585868&view=diff
==============================================================================
---
roller/trunk/app/src/main/java/org/apache/roller/weblogger/ui/struts2/admin/CacheInfo.java
(original)
+++
roller/trunk/app/src/main/java/org/apache/roller/weblogger/ui/struts2/admin/CacheInfo.java
Wed Apr 9 00:46:45 2014
@@ -21,8 +21,6 @@ package org.apache.roller.weblogger.ui.s
import java.util.Collections;
import java.util.List;
import java.util.Map;
-import org.apache.commons.logging.Log;
-import org.apache.commons.logging.LogFactory;
import org.apache.roller.weblogger.pojos.GlobalPermission;
import org.apache.roller.weblogger.ui.struts2.util.UIAction;
import org.apache.roller.weblogger.util.cache.CacheManager;
@@ -33,8 +31,6 @@ import org.apache.roller.weblogger.util.
*/
public class CacheInfo extends UIAction {
- private static Log log = LogFactory.getLog(CacheInfo.class);
-
// map of stats to display
private Map stats = Collections.EMPTY_MAP;
Modified:
roller/trunk/app/src/main/java/org/apache/roller/weblogger/ui/struts2/editor/WeblogConfigBean.java
URL:
http://svn.apache.org/viewvc/roller/trunk/app/src/main/java/org/apache/roller/weblogger/ui/struts2/editor/WeblogConfigBean.java?rev=1585868&r1=1585867&r2=1585868&view=diff
==============================================================================
---
roller/trunk/app/src/main/java/org/apache/roller/weblogger/ui/struts2/editor/WeblogConfigBean.java
(original)
+++
roller/trunk/app/src/main/java/org/apache/roller/weblogger/ui/struts2/editor/WeblogConfigBean.java
Wed Apr 9 00:46:45 2014
@@ -27,7 +27,6 @@ import org.apache.roller.weblogger.pojos
*/
public class WeblogConfigBean {
- private String id = null;
private String handle = null;
private String name = null;
private String description = null;
@@ -58,10 +57,6 @@ public class WeblogConfigBean {
private boolean applyCommentDefaults = false;
- public void setId( String id ) {
- this.id = id;
- }
-
public String getHandle() {
return this.handle;
}
@@ -273,7 +268,6 @@ public class WeblogConfigBean {
public void copyFrom(Weblog dataHolder) {
- this.id = dataHolder.getId();
this.handle = dataHolder.getHandle();
this.name = dataHolder.getName();
this.description = dataHolder.getDescription();
Modified:
roller/trunk/app/src/main/java/org/apache/roller/weblogger/ui/struts2/util/UIAction.java
URL:
http://svn.apache.org/viewvc/roller/trunk/app/src/main/java/org/apache/roller/weblogger/ui/struts2/util/UIAction.java?rev=1585868&r1=1585867&r2=1585868&view=diff
==============================================================================
---
roller/trunk/app/src/main/java/org/apache/roller/weblogger/ui/struts2/util/UIAction.java
(original)
+++
roller/trunk/app/src/main/java/org/apache/roller/weblogger/ui/struts2/util/UIAction.java
Wed Apr 9 00:46:45 2014
@@ -35,12 +35,9 @@ import org.apache.struts2.interceptor.Re
import java.text.DateFormat;
import java.text.SimpleDateFormat;
import java.util.ArrayList;
-import java.util.Arrays;
import java.util.Collections;
import java.util.List;
import java.util.Map;
-import java.util.Set;
-import java.util.HashSet;
/**
* Extends the Struts2 ActionSupport class to add in support for handling an
@@ -393,8 +390,6 @@ public abstract class UIAction extends A
return opts;
}
- private static Set OPEN_CHARS = new HashSet(Arrays.asList('$', '%'));
-
private static String cleanExpressions(String s) {
return (s == null || s.contains("${") || s.contains("%{")) ? "" : s;
}
Modified:
roller/trunk/app/src/main/java/org/apache/roller/weblogger/util/Blacklist.java
URL:
http://svn.apache.org/viewvc/roller/trunk/app/src/main/java/org/apache/roller/weblogger/util/Blacklist.java?rev=1585868&r1=1585867&r2=1585868&view=diff
==============================================================================
---
roller/trunk/app/src/main/java/org/apache/roller/weblogger/util/Blacklist.java
(original)
+++
roller/trunk/app/src/main/java/org/apache/roller/weblogger/util/Blacklist.java
Wed Apr 9 00:46:45 2014
@@ -62,7 +62,7 @@ import org.apache.roller.util.DateUtil;
* @author Lance Lavandowska
* @author Allen Gilliland
*/
-public class Blacklist {
+public final class Blacklist {
private static Log mLogger = LogFactory.getLog(Blacklist.class);
Modified:
roller/trunk/app/src/main/java/org/apache/roller/weblogger/util/BlacklistChecker.java
URL:
http://svn.apache.org/viewvc/roller/trunk/app/src/main/java/org/apache/roller/weblogger/util/BlacklistChecker.java?rev=1585868&r1=1585867&r2=1585868&view=diff
==============================================================================
---
roller/trunk/app/src/main/java/org/apache/roller/weblogger/util/BlacklistChecker.java
(original)
+++
roller/trunk/app/src/main/java/org/apache/roller/weblogger/util/BlacklistChecker.java
Wed Apr 9 00:46:45 2014
@@ -19,8 +19,8 @@ package org.apache.roller.weblogger.util
import java.util.ArrayList;
import java.util.List;
-import org.apache.commons.logging.Log;
-import org.apache.commons.logging.LogFactory;
+import java.util.regex.Pattern;
+
import org.apache.roller.weblogger.config.WebloggerConfig;
import org.apache.roller.weblogger.config.WebloggerRuntimeConfig;
import org.apache.roller.weblogger.pojos.WeblogEntryComment;
@@ -31,9 +31,8 @@ import org.apache.roller.weblogger.pojos
* @author Lance Lavandowska
* @author Dave Johnson
*/
-public class BlacklistChecker {
- private static Log mLogger = LogFactory.getLog(BlacklistChecker.class);
-
+public final class BlacklistChecker {
+
private BlacklistChecker() {
// never instantiable
throw new AssertionError();
@@ -67,8 +66,8 @@ public class BlacklistChecker {
*/
public static boolean checkReferrer(Weblog website, String referrerURL) {
if
(WebloggerConfig.getBooleanProperty("site.blacklist.enable.referrers")) {
- List stringRules = new ArrayList();
- List regexRules = new ArrayList();
+ List<String> stringRules = new ArrayList<String>();
+ List<Pattern> regexRules = new ArrayList<Pattern>();
Blacklist.populateSpamRules(
website.getBlacklist(), stringRules, regexRules, null);
if (WebloggerRuntimeConfig.getProperty("spam.blacklist") != null) {
@@ -86,8 +85,8 @@ public class BlacklistChecker {
*/
private static boolean testComment(WeblogEntryComment c) {
boolean ret = false;
- List stringRules = new ArrayList();
- List regexRules = new ArrayList();
+ List<String> stringRules = new ArrayList<String>();
+ List<Pattern> regexRules = new ArrayList<Pattern>();
Weblog website = c.getWeblogEntry().getWebsite();
Blacklist.populateSpamRules(
website.getBlacklist(), stringRules, regexRules,
Modified:
roller/trunk/app/src/main/java/org/apache/roller/weblogger/util/I18nMessages.java
URL:
http://svn.apache.org/viewvc/roller/trunk/app/src/main/java/org/apache/roller/weblogger/util/I18nMessages.java?rev=1585868&r1=1585867&r2=1585868&view=diff
==============================================================================
---
roller/trunk/app/src/main/java/org/apache/roller/weblogger/util/I18nMessages.java
(original)
+++
roller/trunk/app/src/main/java/org/apache/roller/weblogger/util/I18nMessages.java
Wed Apr 9 00:46:45 2014
@@ -35,7 +35,7 @@ import org.apache.commons.logging.LogFac
/**
* A utility class for handling i18n messaging.
*/
-public class I18nMessages {
+public final class I18nMessages {
private static final Log LOG = LogFactory.getLog(I18nMessages.class);
Modified:
roller/trunk/app/src/main/java/org/apache/roller/weblogger/util/IPBanList.java
URL:
http://svn.apache.org/viewvc/roller/trunk/app/src/main/java/org/apache/roller/weblogger/util/IPBanList.java?rev=1585868&r1=1585867&r2=1585868&view=diff
==============================================================================
---
roller/trunk/app/src/main/java/org/apache/roller/weblogger/util/IPBanList.java
(original)
+++
roller/trunk/app/src/main/java/org/apache/roller/weblogger/util/IPBanList.java
Wed Apr 9 00:46:45 2014
@@ -36,7 +36,7 @@ import org.apache.roller.weblogger.confi
* are also aware of when the file changes via some outside source and we will
* automatically re-read the file and update the list when that happens.
*/
-public class IPBanList {
+public final class IPBanList {
private static Log log = LogFactory.getLog(IPBanList.class);
Modified:
roller/trunk/app/src/main/java/org/apache/roller/weblogger/util/cache/LRUCacheImpl.java
URL:
http://svn.apache.org/viewvc/roller/trunk/app/src/main/java/org/apache/roller/weblogger/util/cache/LRUCacheImpl.java?rev=1585868&r1=1585867&r2=1585868&view=diff
==============================================================================
---
roller/trunk/app/src/main/java/org/apache/roller/weblogger/util/cache/LRUCacheImpl.java
(original)
+++
roller/trunk/app/src/main/java/org/apache/roller/weblogger/util/cache/LRUCacheImpl.java
Wed Apr 9 00:46:45 2014
@@ -23,8 +23,6 @@ import java.util.Date;
import java.util.HashMap;
import java.util.LinkedHashMap;
import java.util.Map;
-import org.apache.commons.logging.Log;
-import org.apache.commons.logging.LogFactory;
import org.apache.roller.util.RollerConstants;
@@ -33,8 +31,6 @@ import org.apache.roller.util.RollerCons
*/
public class LRUCacheImpl implements Cache {
- private static Log log = LogFactory.getLog(LRUCacheImpl.class);
-
private String id = null;
private Map cache = null;
Modified:
roller/trunk/app/src/main/java/org/apache/roller/weblogger/webservices/xmlrpc/BloggerAPIHandler.java
URL:
http://svn.apache.org/viewvc/roller/trunk/app/src/main/java/org/apache/roller/weblogger/webservices/xmlrpc/BloggerAPIHandler.java?rev=1585868&r1=1585867&r2=1585868&view=diff
==============================================================================
---
roller/trunk/app/src/main/java/org/apache/roller/weblogger/webservices/xmlrpc/BloggerAPIHandler.java
(original)
+++
roller/trunk/app/src/main/java/org/apache/roller/weblogger/webservices/xmlrpc/BloggerAPIHandler.java
Wed Apr 9 00:46:45 2014
@@ -31,7 +31,6 @@ import org.apache.commons.lang3.StringUt
import org.apache.commons.logging.Log;
import org.apache.commons.logging.LogFactory;
import org.apache.roller.weblogger.WebloggerException;
-import org.apache.roller.weblogger.config.WebloggerRuntimeConfig;
import org.apache.roller.weblogger.business.Weblogger;
import org.apache.roller.weblogger.business.WebloggerFactory;
import org.apache.roller.weblogger.business.UserManager;
@@ -72,7 +71,7 @@ public class BloggerAPIHandler extends B
* @param password Password for said username
* @param publish Ignored
* @throws XmlRpcException
- * @return
+ * @return true if post deleted, false if entry not found
*/
public boolean deletePost(String appkey, String postid, String userid,
String password, boolean publish) throws Exception {
